From owner-freebsd-stable@FreeBSD.ORG Fri Feb 12 03:26:05 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BD811065670; Fri, 12 Feb 2010 03:26:05 +0000 (UTC) (envelope-from ncrogers@gmail.com) Received: from mail-pz0-f189.google.com (mail-pz0-f189.google.com [209.85.222.189]) by mx1.freebsd.org (Postfix) with ESMTP id 3727C8FC0A; Fri, 12 Feb 2010 03:26:05 +0000 (UTC) Received: by pzk27 with SMTP id 27so717506pzk.27 for ; Thu, 11 Feb 2010 19:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=FGM/yCqP/8Ri/VSBZGSbvcJj7wAYQTwnr2x26PAW7eE=; b=XxLmEMbpb4PZjOQrqoj6Xdk2VWQVV3WjkVmCxU1FnWiFrekQ2XMeOeBomFXBE7sqIL gMQ3QD+J9Ktd+kWPH1LGUjusSosH06haGdCK4THixX3gD/8P2sWkDlPm9T2+2kIYw2d1 4SCLkgbr35IOyNPXZtq7pYU9ESPFsURYg46K4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=f5SzV1D4+q+3VavBTeVOW5GdRJn1NT/bA+08KCcYOVR+6/aphWhnpV81vI5apZl5kn CtdQKGNcAgYMOeBkOGESd9asv2TP8GEhGvd52j8rYpO9nRYoApDqDuzXXCoHvqVPNkLI 1HPmuuJ/FJH3KBgWF5E1lUddi8Edg0dyTWiK8= MIME-Version: 1.0 Received: by 10.143.153.14 with SMTP id f14mr512742wfo.255.1265945164407; Thu, 11 Feb 2010 19:26:04 -0800 (PST) In-Reply-To: <147432021002052044h591c4050ka7f39b4ec739f2a@mail.gmail.com> References: <147432021001310037n1b67f01bx4b4e8781321cea8@mail.gmail.com> <2a41acea1002021443t1c298528i2df3cf40269c733@mail.gmail.com> <2a41acea1002021447t1067ee42gc59b25216270459b@mail.gmail.com> <201002050351.12270.max@love2party.net> <147432021002052044h591c4050ka7f39b4ec739f2a@mail.gmail.com> Date: Thu, 11 Feb 2010 19:26:04 -0800 Message-ID: <147432021002111926x6844a1b7t4e8951223adbdc00@mail.gmail.com> From: Nick Rogers To: Max Laier Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: pyunyh@gmail.com, jfv@freebsd.org, freebsd-stable@freebsd.org, Jack Vogel Subject: Re: em(4) + ALTQ broken X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2010 03:26:05 -0000 Anyone else get a chance to review this? On Fri, Feb 5, 2010 at 8:44 PM, Nick Rogers wrote: > I applied drbr_altq.diff to the e1000 driver (sys/dev/e1000) from HEAD on > top of 8.0-RELEASE kernel sources. It appears to have fixed the immediate > problem where queues simply don't work on em interfaces. Thanks a bunch. > > I suppose further review and testing by others would be greatly appreciated > from my point of view. I am trying to decide on a relatively stable 8.0 > kernel with working em(4) + ALTQ to put into production on 100 or so > installations. Are you guys more comfortable with the HEAD sys/dev/e1000 + > this patch on top of 8.0-RELEASE, or e1000 from 7.2 on top of 8.0-RELEASE? > So far I am having good luck with the later. Thanks again for your > contributions! > > > On Thu, Feb 4, 2010 at 6:51 PM, Max Laier wrote: > >> Okay ... attached is a patch to fix this for em(4) (and lay the groundwork >> to >> fix it for other drbr_* consumer as well). I have tested it in >> VirtualBox, >> but don't have real hardware to check for non-ALTQ performance or other >> regressions. >> >> Test, comments and review appreciated. >> >> -- >> Max >> > >