From owner-freebsd-stable@freebsd.org Thu Jul 25 15:23:23 2019 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60A89A70FA for ; Thu, 25 Jul 2019 15:23:23 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3CF198717C; Thu, 25 Jul 2019 15:23:23 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 715DF26040E; Thu, 25 Jul 2019 17:23:19 +0200 (CEST) Subject: Re: Rel. 11.3: Kernel doesn't compile anymore (SVN-334762, please fix!) To: Peter Cc: freebsd-stable@freebsd.org, Ed Maste , Allan Jude References: <20190724230054.GA81816@gate.oper.dinoex.org> <2a95277f-0646-aeb1-ddf5-9f08bb35161f@selasky.org> <20190725111317.GA82875@gate.oper.dinoex.org> From: Hans Petter Selasky Message-ID: <37114e11-c746-7565-5c57-e51cfdfebb11@selasky.org> Date: Thu, 25 Jul 2019 17:22:41 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190725111317.GA82875@gate.oper.dinoex.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3CF198717C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 15:23:23 -0000 Hi Allan, Can ZFS use atomic_add_64() in the kernel for i386 instead of building its own variant? --HPS On 2019-07-25 13:13, Peter wrote: > Hi Hans Petter, > glad to read You! :) > > On Thu, Jul 25, 2019 at 09:39:26AM +0200, Hans Petter Selasky wrote: > ! On 2019-07-25 01:00, Peter wrote: > > ! >> The offending feature is either > ! >> options ZFS > ! >> or > ! >> device dtrace > ! >> (Adding any of these to the GENERIC config gives the same error.) > > ! Can you attach your kernel configuration file? > > Yes, but to what point? > I can reproduce this with the GENERIC configuration by adding > "options ZFS" > > (My custom KERNCONF relates to my local patches, and is rather > pointless without these. So at first I tried to reproduce without > my local patches and with minimal changes from GENERIC config. And > the minimal change is to add "options ZFS" into the GENERIC conf.) > > See here: > > root@disp:/usr/src/sys/i386/compile/GENERIC # make > linking kernel.full > atomic.o: In function `atomic_add_64': > /usr/src/sys/i386/compile/GENERIC/./machine/atomic.h:629: multiple definition of `atomic_add_64' > opensolaris_atomic.o:/usr/src/sys/i386/compile/GENERIC/../../../cddl/contrib/opensolaris/common/atomic/i386/opensolaris_atomic.S:71: first defined here > *** Error code 1 > > Stop. > make: stopped in /usr/src/sys/i386/compile/GENERIC > root@disp:/usr/src/sys/i386/compile/GENERIC # > > root@disp:/usr/src/sys/i386/compile/GENERIC # cd ../../../.. > root@disp:/usr/src # svn stat > M sys/i386/conf/GENERIC > root@disp:/usr/src # svn diff > Index: sys/i386/conf/GENERIC > =================================================================== > --- sys/i386/conf/GENERIC (revision 350287) > +++ sys/i386/conf/GENERIC (working copy) > @@ -1,3 +1,4 @@ > +options ZFS > # > # GENERIC -- Generic kernel configuration file for FreeBSD/i386 > # > > root@disp:/usr/src # svn info > Path: . > Working Copy Root Path: /usr/src > URL: https://svn0.us-east.freebsd.org/base/releng/11.3 > Relative URL: ^/releng/11.3 > Repository Root: https://svn0.us-east.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 350287 > Node Kind: directory > Schedule: normal > Last Changed Author: gordon > Last Changed Rev: 350287 > Last Changed Date: 2019-07-24 12:58:21 +0000 (Wed, 24 Jul 2019) > > >