From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 8 01:16:56 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 814A316A4CE; Thu, 8 Jul 2004 01:16:56 +0000 (GMT) Received: from mta10.adelphia.net (mta10.adelphia.net [68.168.78.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAC6643D3F; Thu, 8 Jul 2004 01:16:55 +0000 (GMT) (envelope-from johnmary@adelphia.net) Received: from 68-169-191-150.losaca.adelphia.net ([68.169.191.150]) by mta10.adelphia.netESMTP <20040708011655.NWRH12887.mta10.adelphia.net@68-169-191-150.losaca.adelphia.net>; Wed, 7 Jul 2004 21:16:55 -0400 Received: by 68-169-191-150.losaca.adelphia.net (Postfix, from userid 1001) id 57C6C6167; Wed, 7 Jul 2004 18:16:54 -0700 (PDT) From: John Merryweather Cooper To: Adam Weinberger In-Reply-To: <200407080050.i680oKvo031955@freefall.freebsd.org> References: <200407080050.i680oKvo031955@freefall.freebsd.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1089249413.55099.22.camel@68-169-191-150.losaca.adelphia.net> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 07 Jul 2004 18:16:53 -0700 cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68791: [MAINTAINER-UPDATE] Update www/screem to 0.10.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2004 01:16:56 -0000 On Wed, 2004-07-07 at 17:50, Adam Weinberger wrote: > The following reply was made to PR ports/68791; it has been noted by GNATS. > > From: Adam Weinberger > To: John Merryweather Cooper > Cc: FreeBSD gnats submit > Subject: Re: ports/68791: [MAINTAINER-UPDATE] Update www/screem to 0.10.2 > Date: Wed, 7 Jul 2004 20:50:04 -0400 > > >> (07.07.2004 @ 2036 PST): John Merryweather Cooper said, in 5.3K: << > > -# $FreeBSD: ports/www/screem/Makefile,v 1.45 2004/04/18 17:58:59 marcus Exp $ > > +# $FreeBSD$ > > Please don't nuke the $FreeBSD$ line... I quote from the Porter's Handbook: Do not worry about the contents of the $FreeBSD$ line, it will be filled in automatically by CVS when the port is imported to our main ports tree. (Section 3.1) I've been truncating this field for two years at the request of committers and in compliance with the Handbook. It should be truncated by a maintainer. > > > +# HACK: This allows test builds into a temporary directory, but in the REAL world, > > +# gconf would have created this directory. > > +pre-install: > > + @${MKDIR} ${PREFIX}/etc/gconf/gconf.xml.defaults > > This is true of many, many ports. I don't think it should be added to > port Makefiles. It is my philosophy that every port should be able to be built/installed with something like the following command line: # make PREFIX=/tmp/screem install Ports that cannot be built in this manner are, IMO, broken. Without this hack, www/screem (and all other such ports) cannot be built in this manner. The implications are: 1) such ports cannot be easily tested; 2) verifying the contents of the pkg-plist's of such ports is much more difficult; 3) tools such as plist cannot be used to help generate a draft pkg-plist; and 4) such ports are only notionally ${PREFIX} safe. Since this hack does no harm, makes the port truly ${PREFIX} safe, and allows better testing, it should stay in. > > > +@dirrm etc/gconf/schemas > > This directory isn't unique to screem. There shouldn't be an attempt to > delete it (which will necessarily fail, btw). It fails harmlessly, but I missed it (considering the size and complexity of the pkg-plist though, I think I did pretty well). To the committer who finally does this upgrade, please delete this line from the pkg-plist. jmc > > # Adam > > > -- > Adam Weinberger > adamw@magnesium.net || adamw@FreeBSD.org > adamw@vectors.cx || adamw@gnome.org > http://www.vectors.cx > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"