Date: Sat, 8 Oct 2022 13:32:57 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Xin LI <delphij@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: af3c78886fd8 - main - Alter the prototype of qsort_r(3) to match POSIX, which adopted the glibc-based interface. Message-ID: <681762110.6484215.1665235977069@mail.yahoo.com> In-Reply-To: <Y0AlrfmliBbu/t73@FreeBSD.org> References: <202209302230.28UMUq4I029171@gitrepo.freebsd.org> <Y0AlrfmliBbu/t73@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_6484214_924121857.1665235977068 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sorry for top-posting ... Complain here: https://www.austingroupbugs.net/view.php?id=3D900 Pedro. On Friday, October 7, 2022 at 08:12:20 AM GMT-5, Alexey Dokuchaev <danf= e@freebsd.org> wrote: =20 =20 On Fri, Sep 30, 2022 at 10:30:52PM +0000, Xin LI wrote: > commit af3c78886fd8d4ca5eebdbe581a459a6f6d29d6a >=20 >=C2=A0 Alter the prototype of qsort_r(3) to match POSIX, which adopted the >=C2=A0 glibc-based interface. >=20 >=C2=A0 Unfortunately, the glibc maintainers, despite knowing the existence >=C2=A0 of the FreeBSD qsort_r(3) interface in 2004 and refused to add the >=C2=A0 same interface to glibc based on grounds of the lack of standardiza= tion >=C2=A0 and portability concerns, has decided it was a good idea to introdu= ce >=C2=A0 their own qsort_r(3) interface in 2007 as a GNU extension with a >=C2=A0 slightly different and incompatible interface. >=20 >=C2=A0 With the adoption of their interface as POSIX standard, let's switc= h >=C2=A0 to the same prototype, there is no need to remain incompatible. What a sad story, and so unfair to FreeBSD as we now have to deal with compatibility hacks (as mandree@ had said, having to parenthesize a function name is an abomination).=C2=A0 Can you elaborate on technical side= of things a bit?=C2=A0 Is GNU qsort_r(3) interface, while incompatible, better than ours in 1-to-1 comparison, leaving the grief of not going with our older one aside?=C2=A0 Thanks, ./danfe =20 ------=_Part_6484214_924121857.1665235977068 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <html><head></head><body><div class=3D"ydpb4f40c37yahoo-style-wrap" style= =3D"font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px= ;"><div></div> <div dir=3D"ltr" data-setdir=3D"false">Sorry for top-posting ...</d= iv><div dir=3D"ltr" data-setdir=3D"false"><br></div><div dir=3D"ltr" data-s= etdir=3D"false">Complain here:</div><div dir=3D"ltr" data-setdir=3D"false">= <br></div><div dir=3D"ltr" data-setdir=3D"false"><a href=3D"https://www.aus= tingroupbugs.net/view.php?id=3D900" rel=3D"nofollow" target=3D"_blank" clas= s=3D"">https://www.austingroupbugs.net/view.php?id=3D900</a><br></div><div>= <br></div><div><br></div><div dir=3D"ltr" data-setdir=3D"false">Pedro.</div= ><div><br></div> =20 </div><div id=3D"ydp74f8f487yahoo_quoted_5750091912" class=3D"ydp74= f8f487yahoo_quoted"> <div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s= ans-serif;font-size:13px;color:#26282a;"> =20 <div> On Friday, October 7, 2022 at 08:12:20 AM GMT-5, Alexey= Dokuchaev <danfe@freebsd.org> wrote: </div> <div><br></div> <div><br></div> <div>On Fri, Sep 30, 2022 at 10:30:52PM +0000, Xin LI wrote= :<br>> commit af3c78886fd8d4ca5eebdbe581a459a6f6d29d6a<br>> <br>>&= nbsp; Alter the prototype of qsort_r(3) to match POSIX, which adopted the<= br>> glibc-based interface.<br>> <br>> Unfortunately= , the glibc maintainers, despite knowing the existence<br>> of th= e FreeBSD qsort_r(3) interface in 2004 and refused to add the<br>> = same interface to glibc based on grounds of the lack of standardization<b= r>> and portability concerns, has decided it was a good idea to i= ntroduce<br>> their own qsort_r(3) interface in 2007 as a GNU ext= ension with a<br>> slightly different and incompatible interface.= <br>> <br>> With the adoption of their interface as POSIX stan= dard, let's switch<br>> to the same prototype, there is no need t= o remain incompatible.<br><br>What a sad story, and so unfair to FreeBSD as= we now have to deal with<br>compatibility hacks (as mandree@ had said, hav= ing to parenthesize a<br>function name is an abomination). Can you el= aborate on technical side of<br>things a bit? Is GNU qsort_r(3) inter= face, while incompatible, better<br>than ours in 1-to-1 comparison, leaving= the grief of not going with our<br>older one aside? Thanks,<br><br>.= /danfe<br></div> </div> </div></body></html> ------=_Part_6484214_924121857.1665235977068--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?681762110.6484215.1665235977069>