Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Dec 2021 12:51:45 +0100
From:      Gary Jennejohn <gljennjohn@gmail.com>
To:        Konrad Sewi??o-Jopek <kjopek@gmail.com>
Cc:        Alastair Hogge <agh@riseup.net>, freebsd-current@freebsd.org
Subject:   Re: WITHOUT_PF breaks buildworld
Message-ID:  <20211222125145.344d3681@ernst.home>
In-Reply-To: <20211222120401.7a9b7817@ernst.home>
References:  <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> <CAGgez=%2B_jdDn6dfOeo%2BuBeeFNzBfD57HL4wUrw=X-BmGg7mPyg@mail.gmail.com> <20211222120401.7a9b7817@ernst.home>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Dec 2021 12:04:01 +0100
Gary Jennejohn <gljennjohn@gmail.com> wrote:

> On Wed, 22 Dec 2021 08:21:35 +0100
> Konrad Sewi??o-Jopek <kjopek@gmail.com> wrote:
> 
> > Hi,
> > 
> > I think the reason is somewhere in tools/build/test-includes:
> > 
> > --- net/if_pfsync.o ---
> > In file included from net/if_pfsync.c:1:
> > In file included from
> > [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56:
> > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal error:
> > 'netpfil/pf/pf.h' file not found
> > #include <netpfil/pf/pf.h>
> >          ^~~~~~~~~~~~~~~~~
> > 1 error generated.
> > *** [net/if_pfsync.o] Error code 1
> > 
> > make[3]: stopped in [...]freebsd/tools/build/test-includes
> > --- net/pfvar.o ---
> > In file included from net/pfvar.c:1:
> > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal error:
> > 'netpfil/pf/pf.h' file not found
> > #include <netpfil/pf/pf.h>
> >          ^~~~~~~~~~~~~~~~~
> > 1 error generated.
> > *** [net/pfvar.o] Error code 1
> > 
> > make[3]: stopped in [...]freebsd/tools/build/test-includes
> > 2 errors
> > 
> > make[3]: stopped in [...]freebsd/tools/build/test-includes
> > *** [test-includes] Error code 2
> > 
> > make[2]: stopped in [...]freebsd
> > 1 error
> >   
> 
> Could be.  With WITHOUT_PF include/netpfil/pf/pf.h disappears from obj.
> But since buildworld still tries to build net/if_pfsync.c and other
> pf-related binaries the buildworld fails.
> 
> One would thank the WITHOUT_PF should also block building ALL pf-related
> binaries, but that's not the case.
> 

Ah well, pf.h is used in so many places under /usr/src that the best
approach might be to simply remove the WITHOUT_PF build option.

-- 
Gary Jennejohn



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211222125145.344d3681>