From owner-svn-src-head@freebsd.org Thu Nov 26 22:48:02 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B19A5473804; Thu, 26 Nov 2020 22:48:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ChtFZ1zzhz3lBS; Thu, 26 Nov 2020 22:48:01 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id iQ3Pk1l04ktFkiQ3QkexBR; Thu, 26 Nov 2020 15:47:57 -0700 X-Authority-Analysis: v=2.4 cv=NYRYa0P4 c=1 sm=1 tr=0 ts=5fc030a0 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nNwsprhYR40A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=iaTFZB6CAAAA:8 a=VxmjJ2MpAAAA:8 a=EkcXrb_YAAAA:8 a=GY2cRAgL2TZMnOFPKX8A:9 a=CjuIK1q_8ugA:10 a=rBBtE5aJX-cA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=7gXAzLPJhVmCkEl4_tsf:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id A282610B1; Thu, 26 Nov 2020 14:47:54 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 0AQMlrE5071306; Thu, 26 Nov 2020 14:47:53 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202011262247.0AQMlrE5071306@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Stefan Esser cc: Cy Schubert , "O. Hartmann" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests In-reply-to: References: <202011261739.0AQHdpe5012982@repo.freebsd.org> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> <202011262003.0AQK3BTe076596@slippy.cwsent.com> Comments: In-reply-to Stefan Esser message dated "Thu, 26 Nov 2020 22:23:17 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 26 Nov 2020 14:47:53 -0800 X-CMAE-Envelope: MS4xfPB2+lA0Sh3nN6lx7pV8oessqv2J5HXx4vUf5EwzUzOPpcB+EIQHGBt9JKWMSYAxjjzwBRDtTCGTBuXDOg2hIEQYjgvJhopBXUKl1gywFus2ngcuCqxA QzBZp3XdERHfQx+i45sER1P3pSrthDSrCPAE5/8ryFPyn1J43dLFMnWX72isOCh7bYv29AGrj7O9p6jh9JMF6v/vGpNRMVxJEULIIcFII9felOTF8dX4swcF jTl1T82DgOCrOFYADXPzFOGFuV3YDwQimeOOCB+qiLf8poFDya9MKuxOUcxb5nkaRKGxBa9brrH9FSSkJFAgFIj6xsKIFmxfm+bGj0wCRZo= X-Rspamd-Queue-Id: 4ChtFZ1zzhz3lBS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 22:48:02 -0000 In message , Stefan Esser wri tes: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --maOtBJEdTLpVHYJ8ME4Ow5t7gyU1h0CIy > Content-Type: multipart/mixed; boundary="m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ"; > protected-headers="v1" > From: Stefan Esser > To: Cy Schubert > Cc: "O. Hartmann" , src-committers@freebsd.org, > svn-src-all@freebsd.org, svn-src-head@freebsd.org > Message-ID: > Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals > manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests > References: <202011261739.0AQHdpe5012982@repo.freebsd.org> > <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> > <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> > <202011262003.0AQK3BTe076596@slippy.cwsent.com> > In-Reply-To: <202011262003.0AQK3BTe076596@slippy.cwsent.com> > > --m8M7hYutSXzrBuT8orVd2JNQQPKxzBZwZ > Content-Type: text/plain; charset=windows-1252; format=flowed > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > Am 26.11.20 um 21:03 schrieb Cy Schubert:> But this is still a problem: > >=20 > > ld: error: undefined symbol: bc_lib_name > >>>> referenced by vm.c:752 (/opt/src/svn-current/contrib/bc/src/vm.c:752= > ) > >>>> lto.tmp:(bc_vm_boot) > >=20 > > ld: error: undefined symbol: bc_lib > >>>> referenced by lex.c:225 (/opt/src/svn-current/contrib/bc/src/lex.c:2= > 25) > >>>> lto.tmp:(bc_vm_boot) > >>>> referenced by lex.c:227 (/opt/src/svn-current/contrib/bc/src/lex.c:2= > 27) > >>>> lto.tmp:(bc_vm_boot) > > cc: error: linker command failed with exit code 1 (use -v to see invoca= > tion) > > *** [gh-bc.full] Error code 1 > > I cannot reproduce this issue on my system. > > The symbols are defined in files generated by gen/strgen.sh and > there was a change in the parameters passed to this script, but > I had fixed usr.bin/gh-bc/Makefile accordingly (first in the port > and then in base). > > The generated file lib.c should start like this: > ----------------------------------------------------------------- > // Copyright (c) 2018-2020 Gavin D. Howard and contributors. > // Licensed under the 2-clause BSD license. > // *** AUTOMATICALLY GENERATED FROM gen/lib.bc. DO NOT MODIFY. *** > > #if 1 > extern const char *bc_lib_name; > > extern const char bc_lib[]; > > const char *bc_lib_name =3D "gen/lib.bc"; > > const char bc_lib[] =3D > "scale=3D20\n" > ----------------------------------------------------------------- > > This file is generated by this rule in usr.bin/gh-bc/Makefile: > > lib.c: lib.bc > cd ${BCDIR} && sh gen/strgen.sh gen/lib.bc=20 > ${.OBJDIR}/lib.c bc_lib bc_lib_name 1 1 > > By a script that assigns parameters to variables: > > input=3D"$1" > output=3D"$2" > name=3D"$3" > label=3D"$4" > define=3D"$5" > remove_tabs=3D"$6" > > And label=3D"bc_lib_name" is used to generate lib.c as included > above (passed as 4th parameter). > > I'm rebuilding a clean world, now, but I'd be surprised if it failed > after succeeding before readying the commit ... A clean build (sort of) did fix it: rm the appropriate subdir actually. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.