From owner-freebsd-current@FreeBSD.ORG Fri Oct 14 16:23:36 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BDE716A41F for ; Fri, 14 Oct 2005 16:23:36 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99ED943D46 for ; Fri, 14 Oct 2005 16:23:35 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [10.177.171.220] (neutrino.centtech.com [10.177.171.220]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id j9EGNYR4090410; Fri, 14 Oct 2005 11:23:34 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <434FDB70.5040701@centtech.com> Date: Fri, 14 Oct 2005 11:23:12 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.11) Gecko/20050914 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Poul-Henning Kamp References: <9523.1129234887@critter.freebsd.dk> In-Reply-To: <9523.1129234887@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.82/1134/Fri Oct 14 03:07:44 2005 on mh2.centtech.com X-Virus-Status: Clean Cc: FreeBSD Current Subject: Re: ufsstat - testers / feedback wanted! X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2005 16:23:36 -0000 Poul-Henning Kamp wrote: > In message <434EB85A.9030308@centtech.com>, Eric Anderson writes: > >>Poul-Henning Kamp wrote: > > >>>I would far to prefer to see a generic method that would work >>>on all filesystems types, rather than a ufs specific tool. >>> >>>If you added counting code to the VOP_FOO() expansions, you should >>>be able to gather statistics for all filesystem types. >>> >>>The collection could be controlled by a mount option if the impact >>>is too big. >> >>That's an idea I thought of as well, but wanted to start small, since I >>really am new to C programming. Now that I've done this part, I'll look >>at the various vop_* pieces and see if it's something in my grasp. > > > I'd prefer for us to not commit a ufs-only solution, that would be > enough to hold off a filesystem independent solution. True, I see your point. >>From what it sounds like, you'd also like to see per-mount point stats, >>but from the vfs layer, right? If that's true, then do you have any >>suggestions on how to store the statistics for each mounted fs? > > > In struct mount ? Ok - so I'd place my struct vfsstats in the mount struct, so each fs records it's own stats if the mount option is enabled. (reiterating to make sure I'm understanding correctly) Also - is it best to increment the counters at the beginning of the operation, end, or something else? For ufsstat, I placed it at the end, but for some operations, if they fail, the do not get recorded. This may be what we want - only record completed ops, or maybe we want to record all requested operations, completed or not. What are thoughts on this? Thanks.. Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology Anything that works is better than anything that doesn't. ------------------------------------------------------------------------