Date: Tue, 26 Sep 2023 10:32:19 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Warner Losh <imp@bsdimp.com>, Mateusz Guzik <mjg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag Message-ID: <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> In-Reply-To: <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com> References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] In that case, an updated comment seems appropriate, so it’s not removed again. -Ravi (rpokala@) From: <owner-src-committers@freebsd.org> on behalf of Warner Losh <imp@bsdimp.com> Date: Tuesday, September 26, 2023 at 07:51 To: Mateusz Guzik <mjg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag Can you put this back? It is still useful. I have automated scripts that look for this pattern to find the version of a core dump. There are no other ways that are as reliable to find this data. Some other heuristics exist, but my experience with snagging data from maybe a thousand core dumps from $WORK's network found issues in all the alternatives. It's why I didn't whack it already. Even though the text says SCCS which is prehistory for this project, it's still in use today. Warner On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote: The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723 commit e6dc6a27230f836a131118326731b7c5fd417723 Author: Mateusz Guzik <mjg@FreeBSD.org> AuthorDate: 2023-09-26 14:36:51 +0000 Commit: Mateusz Guzik <mjg@FreeBSD.org> CommitDate: 2023-09-26 14:36:51 +0000 sys/conf/newvers.sh: whack sccs tag In the same spirit as removing cvs $FreeBSD$ tags. Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/conf/newvers.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh index 73fd6857d307..18b1817ca287 100644 --- a/sys/conf/newvers.sh +++ b/sys/conf/newvers.sh @@ -311,11 +311,9 @@ fi vers_content_new=$(cat << EOF $COPYRIGHT -#define SCCSSTR "@(#)${VERINFO}" #define VERSTR "${VERSTR}" #define RELSTR "${RELEASE}" -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR; char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR; char compiler_version[] = "${compiler_v}"; char ostype[] = "${TYPE}"; [-- Attachment #2 --] <html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:Monaco; panose-1:2 0 5 0 0 0 0 0 0 0;} @font-face {font-family:"Times New Roman \(Body CS\)"; panose-1:2 2 6 3 5 4 5 2 3 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} span.EmailStyle18 {mso-style-type:personal-reply; font-family:Monaco; font-variant:normal !important; color:windowtext; text-transform:none; position:relative; top:0pt; mso-text-raise:0pt; letter-spacing:0pt; mso-contextual-alternates:no; font-weight:normal; font-style:normal; text-decoration:none none; vertical-align:baseline;} .MsoChpDefault {mso-style-type:export-only; font-size:10.0pt; mso-ligatures:none;} @page WordSection1 {size:8.5in 11.0in; margin:1.0in 1.0in 1.0in 1.0in;} div.WordSection1 {page:WordSection1;} --></style></head><body lang=EN-US link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal><span style='font-size:10.0pt;font-family:Monaco'>In that case, an updated comment seems appropriate, so it’s not removed again.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:Monaco'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:Monaco'>-Ravi (rpokala@)<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:Monaco'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:Monaco'><o:p> </o:p></span></p><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal style='margin-left:.5in'><b><span style='font-size:12.0pt;color:black'>From: </span></b><span style='font-size:12.0pt;color:black'><owner-src-committers@freebsd.org> on behalf of Warner Losh <imp@bsdimp.com><br><b>Date: </b>Tuesday, September 26, 2023 at 07:51<br><b>To: </b>Mateusz Guzik <mjg@freebsd.org><br><b>Cc: </b>src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org><br><b>Subject: </b>Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag<o:p></o:p></span></p></div><div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p></div><div><p class=MsoNormal style='margin-left:.5in'>Can you put this back? It is still useful. I have automated scripts that look for this pattern to find the version of a core dump. There are no other ways that are as reliable to find this data. Some other heuristics exist, but my experience with snagging data from maybe a thousand core dumps from $WORK's network found issues in all the alternatives. It's why I didn't whack it already. Even though the text says SCCS which is prehistory for this project, it's still in use today.<o:p></o:p></p><div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p></div><div><p class=MsoNormal style='margin-left:.5in'>Warner<o:p></o:p></p></div></div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p><div><div><p class=MsoNormal style='margin-left:.5in'>On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <<a href="mailto:mjg@freebsd.org">mjg@freebsd.org</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal style='margin-left:.5in'>The branch main has been updated by mjg:<br><br>URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723</a><br><br>commit e6dc6a27230f836a131118326731b7c5fd417723<br>Author: Mateusz Guzik <mjg@FreeBSD.org><br>AuthorDate: 2023-09-26 14:36:51 +0000<br>Commit: Mateusz Guzik <mjg@FreeBSD.org><br>CommitDate: 2023-09-26 14:36:51 +0000<br><br> sys/conf/newvers.sh: whack sccs tag<br><br> In the same spirit as removing cvs $FreeBSD$ tags.<br><br> Sponsored by: Rubicon Communications, LLC ("Netgate")<br>---<br> sys/conf/newvers.sh | 2 --<br> 1 file changed, 2 deletions(-)<br><br>diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh<br>index 73fd6857d307..18b1817ca287 100644<br>--- a/sys/conf/newvers.sh<br>+++ b/sys/conf/newvers.sh<br>@@ -311,11 +311,9 @@ fi<br><br> vers_content_new=$(cat << EOF<br> $COPYRIGHT<br>-#define SCCSSTR "@(#)${VERINFO}"<br> #define VERSTR "${VERSTR}"<br> #define RELSTR "${RELEASE}"<br><br>-char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR;<br> char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR;<br> char compiler_version[] = "${compiler_v}";<br> char ostype[] = "${TYPE}";<o:p></o:p></p></blockquote></div></div></body></html>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52507A54-AAB7-43E9-BD06-41B9C78CF296>