From owner-svn-src-stable@freebsd.org Fri Mar 17 00:57:57 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6F38D0EC02; Fri, 17 Mar 2017 00:57:57 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E1EC1111; Fri, 17 Mar 2017 00:57:56 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id ogDKcGuwi47SdogDLcdzKl; Thu, 16 Mar 2017 18:57:55 -0600 X-Authority-Analysis: v=2.2 cv=P9pKvmIu c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=6Iz7jQTuP9IA:10 a=pGLkceISAAAA:8 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=QyXUC8HyAAAA:8 a=YxBL1-UpAAAA:8 a=zHFK984VsUyzW9ukltwA:9 a=CjuIK1q_8ugA:10 a=6kGIvZw6iX1k4Y-7sg4_:22 a=IjZwj45LgO3ly-622nXo:22 a=pxhY87DP9d2VeQe4joPk:22 a=avl4LiGQNoF5OB0DmCJ7:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 57D70C27; Thu, 16 Mar 2017 17:57:54 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v2H0vr29087029; Thu, 16 Mar 2017 17:57:53 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201703170057.v2H0vr29087029@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Eric Joyner cc: Ngie Cooper , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv In-Reply-To: Message from Eric Joyner of "Thu, 16 Mar 2017 18:59:31 -0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 16 Mar 2017 17:57:53 -0700 X-CMAE-Envelope: MS4wfN2r2OoDF3DGngDMimpRwiBQVxE6x9s4GiaToENFil7pJfetUzVQVDywMD1NAlgz/xYCYxiKTXzKPMMwcQe8dWCeZhJccnahzVEot57f2+CDcF4jkQmB u77REJNBRCIsWk094K1VwKeJI4EDfpimHteELBQw+LtJvILUmUomLcbQurqUmn3FoCvXwKNGRLG9HzUmxOUnfrxpRjibWGdOmHwwzN7JGdEpfrmwZB5ikePi bttzptMWXtR+Fv1JtBMCevlfRFA+3zHXxw3L5PMmOxFdSMEJ58AfaPqE4NrQbryvyITiVrAIMNSVsTgcLKKcJ37JOInw6hke6d6EjsLx5uUTFGxazb///wxP YBr5Koef X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 00:57:57 -0000 In message , Eric Joyner writes: > --94eb2c18d092e83944054adda9b6 > Content-Type: text/plain; charset=UTF-8 > > Ngie, > > It looks like what's in the commit is using an older version of netmap, so > I think we're okay on that. I think the naming conflict may be due to > splitting the ixgbe_netmap.c file into ixgbe_netmap.c & ixv_netmap.c, and > not having the functions in ixv_netmap.c be renamed. > > I don't think the PCI_IOV stuff should be left in there. At least from what > I gathered in D4767, it's probably abandoned in 10. > > Cy, > > Are you using special options in your kernel config file? "device ixgbe" > works for me, so I want to assume you have "device netmap" in your config > file, unless you're missing INET and/or INET6. > > On Thu, Mar 16, 2017 at 10:00 AM Ngie Cooper wrote: > > > > > On Mar 16, 2017, at 09:29, Eric Joyner wrote: > > > > I'm looking at this now. > > > > Cy, in your case it sounds like the "device ixgbe" option is broken. I'll > > work on getting that to build again. I don't specify ix or ixgbe. Just a module build. I disconnected it to allow the build to finish. > > > > The LINT build error looks like a netmap linking issue (probably due to > > Jeb moving/copying netmap stuff into the driver folder), so that'll be fun > > to root cause. > > > > > > Hi Eric, > > One sandtrap to be aware of is r307394 (and corresponding commits) > > not being MFCed, along with a host of PCI-IOV, etc changes not being easily > > backportable. > > If you can, look for commits from me in the r29xxxx series citing > > ix_crcstrip (it was a backport from bz@ to unbreak LINT on head that also > > fixed stable/10). > > Thanks! > > -Ngie > > > > On Thu, Mar 16, 2017 at 7:10 AM Cy Schubert > > wrote: > > > > In message <62C8A9FD-1EE0-4DEF-A28A-843DBBB4972A@gmail.com>, "Ngie Cooper > > (yane > > urabeya)" writes: > > > > > > --Apple-Mail=_BD9D96B3-A5E1-4DF6-8A1A-EEC15F03AFC5 > > > Content-Transfer-Encoding: quoted-printable > > > Content-Type: text/plain; > > > charset=us-ascii > > > > > > > > > > On Mar 15, 2017, at 14:20, Eric Joyner wrote: > > > >=20 > > > > Author: erj > > > > Date: Wed Mar 15 21:20:17 2017 > > > > New Revision: 315333 > > > > URL: https://svnweb.freebsd.org/changeset/base/315333 > > > >=20 > > > > Log: > > > > ixgbe(4): Update to 3.2.11-k > > > >=20 > > > > Includes: > > > >=20 > > > > 1. Support for X553 (Denverton) Ethernet devices. > > > > 2. Initialization code refactoring. > > > > 3. ixgbe-specific netmap code moved to ixgbe folder > > > > (but not removed from dev/netmap/). > > > > 4. VF driver full split. Some cleanup can be had due to redundant = > > > code, > > > > but this split goes inline with the refactoring. > > > >=20 > > > > NOTE: This is a direct commit to stable/10. Newer branches will = > > > receive an > > > > iflib-converted version of ixgbe, with these updates included, = > > > instead. > > > >=20 > > > > Differential Revision: https://reviews.freebsd.org/D9310 > > > > Submitted by: Jeb Cramer (jeb.j.cramer@intel.com) > > > > Tested by: Jeffrey Pieper (jeffrey.e.pieper@intel.com) > > > > Sponsored by: Intel Corporation > > > > > > Hi Eric, > > > This commit broke amd64/LINT, further (there are other issues = > > > preventing it from passing): = > > > https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-LINT/543/console . > > > > It also broke buildkernel while building the ixgbe module in my > > stable10/amd64 VM. > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: http://www.FreeBSD.org > > > > The need of the many outweighs the greed of the few. > > > > > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.