From owner-freebsd-current@FreeBSD.ORG Sat Nov 21 23:44:02 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC6F7106566C for ; Sat, 21 Nov 2009 23:44:02 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 3CDF98FC08 for ; Sat, 21 Nov 2009 23:44:01 +0000 (UTC) Received: by bwz5 with SMTP id 5so4525643bwz.3 for ; Sat, 21 Nov 2009 15:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=PSvVkprGZs4IzREUAC08fOsn0+NrrGzHTIPKAZmBb/k=; b=itU/Bpko6D4jK7AJD0UTMWoyzaw3tJ8ppDJTq3RPweW5ru55YFt856kmqIDgHi1VyB 6fU5mUe7rZ7UkuoziWFhMX94ykzB0KtdP4XwPvjVPEjT2QrFZaRbPqDrUu3jcV85OlMV 7FUNySukjtHH0gjBTzEKWPOpFrKn9IDNUSiGg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=squklKSjjZo0OVMOmAvXhsRdMgGe+Ye4gJi+RizQU6Qd1tIyWhwukbF3FEdFLuG4WV r3/oKukE+V5pmfxu8yHEGDqDw7EFAAn37cV+s1u46vEjjxZ7TiO49tkYAGmuBDyXzAy1 Tyh3JG/wfoe2vEv3ZMsh7bI3lhpwDww4sdAO0= MIME-Version: 1.0 Received: by 10.204.48.202 with SMTP id s10mr614947bkf.106.1258847041080; Sat, 21 Nov 2009 15:44:01 -0800 (PST) In-Reply-To: <4B08275A.3070209@gwdg.de> References: <4B05C709.2090005@dougbarton.us> <20091120110123.GG2331@deviant.kiev.zoral.com.ua> <4b069fec.141bf30a.7f54.ffff8735@mx.google.com> <4B06BCC5.1000806@gwdg.de> <4B08275A.3070209@gwdg.de> Date: Sat, 21 Nov 2009 23:44:01 +0000 Message-ID: <6101e8c40911211544y2347b832kda66f3217fb6aa55@mail.gmail.com> From: Oliver Pinter To: Rainer Hurling Content-Type: text/plain; charset=ISO-8859-1 Cc: Kostik Belousov , Aditya Sarawgi , freebsd-current@freebsd.org, delphij@freebsd.org, dougb@dougbarton.us Subject: Re: multimedia/vlc causes a panic if media files are on msdosfs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Nov 2009 23:44:02 -0000 can you run memtest? On 11/21/09, Rainer Hurling wrote: > On 20.11.2009 16:59 (UTC+1), Rainer Hurling wrote: >> On 20.11.2009 20:26 (UTC+1), Aditya Sarawgi wrote: >>> On Fri, Nov 20, 2009 at 01:01:23PM +0200, Kostik Belousov wrote: >>>> On Thu, Nov 19, 2009 at 02:30:33PM -0800, Doug Barton wrote: >>>>> Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=140648 for more >>>>> information, including a trace. >>>>> >>>>> There is also some evidence that the same problem is triggered by >>>>> accessing files on an NTFS partition. The VLC folks have suggested >>>>> that the problem may be related to threading. >>>> This is because msdosfs and ntfs are not mpsafe, and it seems that >>>> VLC using recently added F_RDAHEAD/F_READAHEAD fcntls. >>>> >>>> Please try this. >>>> >>>> diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c >>>> index 434f54a..676de65 100644 >>>> --- a/sys/kern/kern_descrip.c >>>> +++ b/sys/kern/kern_descrip.c >>>> @@ -718,14 +718,15 @@ kern_fcntl(struct thread *td, int fd, int cmd, >>>> intptr_t arg) >>>> do { >>>> new = old = fp->f_flag; >>>> new |= FRDAHEAD; >>>> - } while (atomic_cmpset_rel_int(&fp->f_flag, old, new) == >>>> 0); >>>> + } while (!atomic_cmpset_rel_int(&fp->f_flag, old, new)); >>>> readahead_vnlock_fail: >>>> VFS_UNLOCK_GIANT(vfslocked); >>>> + vfslocked = 0; >>>> } else { >>>> do { >>>> new = old = fp->f_flag; >>>> new &= ~FRDAHEAD; >>>> - } while (atomic_cmpset_rel_int(&fp->f_flag, old, new) == >>>> 0); >>>> + } while (!atomic_cmpset_rel_int(&fp->f_flag, old, new)); >>>> } >>>> fdrop(fp, td); >>>> break; >>> >>> I have been getting panics with VLC on UFS filesytem too, Although the >>> frequency of panics on a UFS filesystem is pretty low as compared to >>> msdosfs and ntfs systems and they are very abrupt. I will try getting >>> a trace. >> >> I am observing panics also with newest vlc port on ufs2. System panics >> whenever playing .flv files. > > With this patch even my panics went away :-) > > Thank you very much, > Rainer Hurling > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >