From owner-cvs-ports@FreeBSD.ORG  Sun Jan  2 07:11:43 2005
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6DE0216A4CE; Sun,  2 Jan 2005 07:11:43 +0000 (GMT)
Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 925E643D41; Sun,  2 Jan 2005 07:11:42 +0000 (GMT)
	(envelope-from edwin@mavetju.org)
Received: by mail2out.barnet.com.au (Postfix, from userid 27)
	id 1711E707428; Sun,  2 Jan 2005 18:11:39 +1100 (EST)
X-Viruscan-Id: <41D79EAB0000A3B940B20A@BarNet>
Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	Authority" (verified OK))
	by mail2.barnet.com.au (Postfix) with ESMTP id CAD80707426;
	Sun,  2 Jan 2005 18:11:38 +1100 (EST)
Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	Certificate Authority" (verified OK))
	by mail2-auth.barnet.com.au (Postfix) with ESMTP id 43ED47073CE;
	Sun,  2 Jan 2005 18:11:38 +1100 (EST)
Received: by k7.mavetju (Postfix, from userid 1001)
	id 1635760EA; Sun,  2 Jan 2005 18:11:37 +1100 (EST)
Date: Sun, 2 Jan 2005 18:11:36 +1100
From: Edwin Groothuis <edwin@mavetju.org>
To: Xin LI <delphij@frontfree.net>
Message-ID: <20050102071136.GD1436@k7.mavetju>
References: <200501020116.j021GBqD070105@repoman.freebsd.org>
	<20050102064857.GA4047@frontfree.net>
	<20050102065949.GB6250@xor.obsecurity.org>
	<20050102070800.GA106@frontfree.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050102070800.GA106@frontfree.net>
User-Agent: Mutt/1.5.6i
cc: cvs-ports@FreeBSD.org
cc: Kris Kennaway <kris@FreeBSD.org>
cc: ports-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: ports/mail/postfix-gps Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jan 2005 07:11:43 -0000

On Sun, Jan 02, 2005 at 03:08:00PM +0800, Xin LI wrote:
> I think a better way is to have bsd.port.mk to set WITH_FOO or WITHOUT_FOO
> according to the defaults set in individual ports' Makefile.  It seems that
> bsd.port.mk will ignore OPTIONS when doing package builds.

They did this on purpose, see the part of bsd.port.mk which starts with:
    ################################################################
    #
    # Do preliminary work to detect if we need to run the config
    # target or not.
    #
    ################################################################

I am totally on your side with this, bsd.port.mk should set the
default WITH_ and WITHOUT_s.

Edwin

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/