From owner-freebsd-scsi@FreeBSD.ORG Wed Jan 29 18:59:27 2014 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AF9D465; Wed, 29 Jan 2014 18:59:27 +0000 (UTC) Received: from mta05.bitpro.no (mta05.bitpro.no [92.42.64.202]) by mx1.freebsd.org (Postfix) with ESMTP id 0189C19CA; Wed, 29 Jan 2014 18:59:26 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta05.bitpro.no (Postfix) with ESMTPS id F0EFA17FC8D; Wed, 29 Jan 2014 19:59:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id E72EF8F81BD; Wed, 29 Jan 2014 20:00:10 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kdl8Y78qmjWZ; Wed, 29 Jan 2014 20:00:10 +0100 (CET) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id 1517E8F81AD; Wed, 29 Jan 2014 20:00:10 +0100 (CET) Message-ID: <52E94FC2.1010901@bitfrost.no> Date: Wed, 29 Jan 2014 20:00:18 +0100 From: Hans Petter Selasky Organization: Bitfrost A/S User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Garrett Wollman , freebsd-stable@freebsd.org, freebsd-scsi@freebsd.org Subject: Re: stable/9 mps(4) rev 254938 == BOOM! References: <21225.19508.683025.581620@khavrinen.csail.mit.edu> In-Reply-To: <21225.19508.683025.581620@khavrinen.csail.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: scottl@freebsd.org, ken@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 18:59:27 -0000 On 01/29/14 19:45, Garrett Wollman wrote: > I've been trying to puzzle out why the USB stack hits a GPF during > boot on 9-stable on one of my machines (which runs 9.2 just fine), and > by trial and error I've found that it is actually caused by r254938, > which is a mega-MFC of mps(4) driver changes, even though the fault > always occurs at the same place in a harmless USB subroutine. Details > below; config available on request. > > -GAWollman Hi, To me this sounds like someone is writing outside their assigned area. options DEBUG_REDZONE Maybe some change that should have been MFC'ed did not get MFC'ed. I think you can copy the mps driver from -current just keeping the following deltas intact: - - if (curthread->td_no_sleeping != 0) + + if(curthread->td_pflags & TDP_NOSLEEPING) sleep_flags = NO_SLEEP; --HPS