From owner-cvs-all@FreeBSD.ORG  Wed Feb 23 06:30:46 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A687216A4CE; Wed, 23 Feb 2005 06:30:46 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F0AFB43D2F; Wed, 23 Feb 2005 06:30:45 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j1N6Ue4n058140;
	Wed, 23 Feb 2005 07:30:40 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Jeff Roberson <jroberson@chesapeake.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 22 Feb 2005 18:03:58 EST."
             <20050222180223.V52537@mail.chesapeake.net> 
Date: Wed, 23 Feb 2005 07:30:40 +0100
Message-ID: <58139.1109140240@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys vnode.h 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Feb 2005 06:30:46 -0000

In message <20050222180223.V52537@mail.chesapeake.net>, Jeff Roberson writes:
>On Tue, 22 Feb 2005, Poul-Henning Kamp wrote:
>
>> phk         2005-02-22 18:49:03 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/sys              vnode.h
>>   Log:
>>   Group the fields in struct vnode by their function and stick comments
>>   there to tell what the function is.
>
>They were sorted according to the lock that they used.  I still prefer
>that, prehaps with sorting by use secondly.

That doesn't make sense.  The comment says which lock they use so people
can still see that, but appearantly people had big trouble seeing what
fields belonged where.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.