Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Sep 2004 02:15:43 +0800 (CST)
From:      Yen-Ming Lee <leeym@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        marcus@FreeBSD.org
Subject:   ports/71564: [PATCH] devel/portlint: check USE_GETTEXT
Message-ID:  <20040910181543.999093EAD72@utopia.leeym.com>
Resent-Message-ID: <200409101820.i8AIKO8Y007114@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         71564
>Category:       ports
>Synopsis:       [PATCH] devel/portlint: check USE_GETTEXT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 10 18:20:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD utopia.leeym.com 5.3-BETA3 FreeBSD 5.3-BETA3 #4: Fri Sep 10 05:12:41 CST 2004
>Description:

- check if *.mo files installed without defining USE_GETTEXT
  (use bundled libintl may install other useless reference files: ports/71531)

Port maintainer (marcus@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- portlint-2.6.7.patch begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.63
diff -u -u -r1.63 portlint.pl
--- src/portlint.pl	1 Sep 2004 04:13:32 -0000	1.63
+++ src/portlint.pl	10 Sep 2004 18:07:01 -0000
@@ -174,7 +174,7 @@
 	MASTER_SITES WRKDIR WRKSRC NO_WRKSUBDIR PATCHDIR SCRIPTDIR FILESDIR
 	PKGDIR COMMENT DESCR PLIST PKGCATEGORY PKGINSTALL PKGDEINSTALL
 	PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB USE_LIBTOOL_VER
-	INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER
+	INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER USE_GETTEXT
 );
 
 my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist);
@@ -753,6 +753,11 @@
 
 		if ($_ =~ /^share\/examples\//) {
 			&perror("WARN: $file [$.]: consider using EXAMPLESDIR macro");
+		}
+
+		if ($_ =~ /\.mo$/ && $makevar{USE_GETTEXT} eq '') {
+			&perror("WARN: $file [$.]: installing GNU message catalogs, ".
+				"please define USE_GETTEXT as appropriate.");
 		}
 
 		if ($_ =~ m#man/([^/]+/)?man([$manchapters])/([^\.]+\.[$manchapters])(\.gz)?$#) {
--- portlint-2.6.7.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040910181543.999093EAD72>