From owner-svn-src-head@FreeBSD.ORG Sat Jun 6 17:15:25 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 010F2991; Sat, 6 Jun 2015 17:15:24 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C532E10BB; Sat, 6 Jun 2015 17:15:24 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from [192.168.2.22] (atc.xcllnt.net [50.0.150.213]) (authenticated bits=0) by mail.xcllnt.net (8.14.9/8.14.9) with ESMTP id t56HFN2t029628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Jun 2015 10:15:24 -0700 (PDT) (envelope-from marcel@xcllnt.net) Subject: Re: svn commit: r284078 - head/sys/dev/pci Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_FBE037D9-E3C9-4A6D-9C9A-5524928D5E16"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Marcel Moolenaar In-Reply-To: <5117505.v1AmJczBtP@ralph.baldwin.cx> Date: Sat, 6 Jun 2015 10:15:23 -0700 Cc: Marcel Moolenaar , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <683C7AD0-A2E7-4EA8-8F98-D1D52F40C073@xcllnt.net> References: <201506061551.t56FpCbX013048@svn.freebsd.org> <14005803.mtbqcRkBJG@ralph.baldwin.cx> <5117505.v1AmJczBtP@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jun 2015 17:15:25 -0000 --Apple-Mail=_FBE037D9-E3C9-4A6D-9C9A-5524928D5E16 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 6, 2015, at 10:08 AM, John Baldwin wrote: >=20 > On Saturday, June 06, 2015 09:18:22 AM Marcel Moolenaar wrote: >>=20 >>> On Jun 6, 2015, at 9:03 AM, John Baldwin wrote: >>>=20 >>> On Saturday, June 06, 2015 03:51:12 PM Marcel Moolenaar wrote: >>>> Author: marcel >>>> Date: Sat Jun 6 15:51:11 2015 >>>> New Revision: 284078 >>>> URL: https://svnweb.freebsd.org/changeset/base/284078 >>>>=20 >>>> Log: >>>> Don't return -10000 as the probe priority. That's lower than what >>>> BUS_PROBE_HOOVER is. Drivers like proto(4), when compiled into the >>>> kernel or preloaded, will render your system useless by virtue of >>>> attaching to your PCI busses. >>>>=20 >>>> Return BUS_PROBE_GENERIC instead. It's just the next priority up >>>> from BUS_PROBE_HOOVER. No other meaning has been give to its use. >>>> While BUS_PROBE_DEFAULT seems like a better candidate, it's hard >>>> not to think that there must be some reason why these drivers >>>> return -10000 in the first place. >>>=20 >>> BUS_PROBE_DEFAULT would conflict with other drivers that are = supposed to >>> override these, such as acpi_pcib_pci which should override pci_pci >>> for PCI-PCI bridges in the ACPI namespace. That driver currently = hardcodes >>> -1000 itself. :-/ Then there's pcibios_pcib_probe for the $PIR = PCI-PCI >>> bridge driver for when ACPI isn't present. It returns -2000. The >>> MPTable PCI-PCI bridge driver returns -1000 like ACPI. >>=20 >> So that means we have a regression. Do you want me to back out >> or should we just move forward and fix those too. >=20 > Yeah, I just now realized this. If you can fix this quickly it's = probably ok > to just fix it vs backing it out and committing a larger change. I opted to back it out. I searched for all drivers that use BUS_PROBE_HOOVER and it=E2=80=99s exactly one: proto(4). That=E2=80=99s = a lot easier then finding all drivers that return some negative value that has some relation to PCI busses... I=E2=80=99m just going to change BUS_PROBE_HOOVER to -1000000 instead. In follow-up rounds we can change magical constants to defines to make the whole pecking order more obvious/visible. -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_FBE037D9-E3C9-4A6D-9C9A-5524928D5E16 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVcyqrAAoJEIda8t8f0tjjfU4P/iy/9ndUZZSrzUucN3QeaeMs n3Clkr02dE0e6PFNiJat8ENfB/oE+CUiFiqzR+3Fr9DAerPmrWsnVaF0U7jpgJd5 YSMS9y32h93Rng0fnB2w1UMU3UTqNp0m2ulc8tSz69igMAq65rfHEPnIIW5z/CAq pne41DLIqWDCam73MUao+BsPfSPy/9A4MBSYEvJyVQfa4UHXJkdMYqEIidz9ps0T 2AWI0nzpoJd5p04EAqWD86FYt/DKP3tigmBKv0kkrf/Dn5AprcjWFeIAQDa1rLHs MjMP6jaKf81m9lf3XMzmz93m5GItapwLHmlUK8rkX19BvfQgSXyJYIgYtDDBU0i2 c4aJorl8Zes6Ovk2gThYVAgZb4Lw4J6YZdqSvdBH9j5ok8j91SOgrnROzmaBmuIu /jKt6xhK6SwyhsZpSSSt0g9oO+l5eYXQmUJ2J88fKrm5X3eGOC5OzJucHCh/NuoL rC9y42o+bm7pcSmhww959+rrFYulYs673OgTdYT+ldvY7vwFN18qE1iYmtXZNVo5 XQReKjbyfnopc5DJrtiA4ra9v3Ikr1Ca8xN4hM+UTRJiJkTbYnUTJJ/HjY5Hk1rV 4Rb1kWqLhYCchLGvCNKh/F7alJ7LE2DIKkLPTaEuWEi+BAhyRasrZZhccdJxz9Em dysTP8MaNoP3TZtdJ7kz =AG/H -----END PGP SIGNATURE----- --Apple-Mail=_FBE037D9-E3C9-4A6D-9C9A-5524928D5E16--