From nobody Thu Dec 18 03:24:26 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dWwyJ01jsz6K5Ys; Thu, 18 Dec 2025 03:24:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4dWwyH3bR8z45d3; Thu, 18 Dec 2025 03:24:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 5BI3OQdB087466; Thu, 18 Dec 2025 05:24:29 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 5BI3OQdB087466 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 5BI3OQaU087465; Thu, 18 Dec 2025 05:24:26 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 18 Dec 2025 05:24:26 +0200 From: Konstantin Belousov To: Vladimir Kondratyev Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org, kevans@freebsd.org Subject: Re: git: d3690a599586 - stable/15 - devfs: make destroy_dev() a release barrier for cdevpriv destructors runs Message-ID: References: <69431ba8.40557.13f66fa4@gitrepo.freebsd.org> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69431ba8.40557.13f66fa4@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dWwyH3bR8z45d3 On Wed, Dec 17, 2025 at 09:07:52PM +0000, Vladimir Kondratyev wrote: > The branch stable/15 has been updated by wulf: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d3690a5995867e35d4d1dc63127343d4b0a092d6 > > commit d3690a5995867e35d4d1dc63127343d4b0a092d6 > Author: Konstantin Belousov > AuthorDate: 2025-10-23 18:37:00 +0000 > Commit: Vladimir Kondratyev > CommitDate: 2025-12-17 21:05:38 +0000 > > devfs: make destroy_dev() a release barrier for cdevpriv destructors runs > > Ensure that all destructors for cdevpriv finished running before > destroy_dev() returns to the caller. Otherwise, since > devfs_destroy_cdevpriv() removes the cdevpriv data from the list, drops > the cdevpriv_mtx, and then starts the destructor, it is possible for > destroy_dev() to return before destructor finished in other thread. > > This should allow drivers to safely remove cdev instance data that might > be referenced by cdevpriv data. > > Diagnosed by: kevans > Reviewed by: kevans, markj > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D53303 > > (cherry picked from commit 4dbe6628179d8e6bf400bfdb4bfa869bdc102a56) I did not merged this to 15 (or 14) because if_tun has a regressions requiring some fixes from kevans, which were not merged.