From owner-svn-src-all@freebsd.org Thu Jan 26 06:32:50 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 893A5CC2095; Thu, 26 Jan 2017 06:32:50 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A026F0D; Thu, 26 Jan 2017 06:32:50 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-it0-x244.google.com with SMTP id o185so4369494itb.1; Wed, 25 Jan 2017 22:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=K7m6eQB7xQAWquPPBRBVWCryS3Ut/wUUGZx5LPtPmzM=; b=bLkjdDvdJceuApONJa5Wm9Onw8Wr0urFczZNUCNbvnyDvb7Stzh3MDXYW/cEMLrizh c1xUCPyLTjqdfHIDq1aJFii3vj9ugvIifPWCR7zcFhhv+SFpJs4zMZ7jO138nh1IWPuI q1OhLNhk2EASNzGdA5oGc4zleBagcM8WbsWTslUm/UJDyvPV1rZbK2oY6g2U2kS/mENJ EkydZg1bvIsRcKNg5nBPh7Mqjkket/uSrVaNc10qyFq+9/QdiBK//x3AE8k//khTZbqE E9kIL+jiL+MQT6CScmlbSxTjnPuabFHCSMoehp99lz1WclLYz/B1BQWUy/C8X8phrO+G e53w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=K7m6eQB7xQAWquPPBRBVWCryS3Ut/wUUGZx5LPtPmzM=; b=WPLzn2nrz+ajA38UoRy4eDKZ2MnXfSiDNRK7LwB6HXD2DNW/9VikORU6HVC7DlCgSU r4tBPCZevTva9wNRZIj5fTltv9OJl1JP1sWGK1+yvckN6mtBUuVT9WdSeK0rKbOkydVe xL+XNewxO+f6uKLJABZPOxIEAvKVZUnP7+Uam4YqJqVBm6PMTfhFN2oijNPA8D5HFPG5 a2S16V1YCxiSJP2U9FnBlfICJHsu93M7j0h3uyvj/OgCtxjGsmZSJOPU4lA/mncPas5+ 22gKdOsoOSwflRsru2JjbPybGeIEM0mERaR3F+FpMbc0fIqYN+Nm8ZXdh6dyuBiT9P5H lg9A== X-Gm-Message-State: AIkVDXLv6ov+Ul/Bj+t035d3f8NOdveosGjyL21O/1M5xC8Xf+kzvti/n9YPpZY8Oi7fLtK0PIfLEzwGWHPRmg== X-Received: by 10.36.76.205 with SMTP id a196mr1503295itb.52.1485412369294; Wed, 25 Jan 2017 22:32:49 -0800 (PST) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 10.107.205.142 with HTTP; Wed, 25 Jan 2017 22:32:48 -0800 (PST) In-Reply-To: <201701251759.v0PHxMWN032521@repo.freebsd.org> References: <201701251759.v0PHxMWN032521@repo.freebsd.org> From: Antoine Brodin Date: Thu, 26 Jan 2017 07:32:48 +0100 X-Google-Sender-Auth: CW_9XsYLF2NelmIyas1gJd3-XJA Message-ID: Subject: Re: svn commit: r312765 - in head/contrib/llvm: include/llvm/Analysis lib/Analysis To: Dimitry Andric Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2017 06:32:50 -0000 On Wed, Jan 25, 2017 at 6:59 PM, Dimitry Andric wrote: > Author: dim > Date: Wed Jan 25 17:59:22 2017 > New Revision: 312765 > URL: https://svnweb.freebsd.org/changeset/base/312765 > > Log: > Pull in r276136 from upstream llvm trunk (by Wei Mi): > > Use ValueOffsetPair to enhance value reuse during SCEV expansion. > > In D12090, the ExprValueMap was added to reuse existing value during > SCEV expansion. However, const folding and sext/zext distribution can > make the reuse still difficult. > > A simplified case is: suppose we know S1 expands to V1 in > ExprValueMap, and > S1 = S2 + C_a > S3 = S2 + C_b > where C_a and C_b are different SCEVConstants. Then we'd like to > expand S3 as V1 - C_a + C_b instead of expanding S2 literally. It is > helpful when S2 is a complex SCEV expr and S2 has no entry in > ExprValueMap, which is usually caused by the fact that S3 is > generated from S1 after const folding. > > In order to do that, we represent ExprValueMap as a mapping from SCEV > to ValueOffsetPair. We will save both S1->{V1, 0} and S2->{V1, C_a} > into the ExprValueMap when we create SCEV for V1. When S3 is > expanded, it will first expand S2 to V1 - C_a because of S2->{V1, > C_a} in the map, then expand S3 to V1 - C_a + C_b. > > Differential Revision: https://reviews.llvm.org/D21313 > > This should fix assertion failures when building OpenCV >= 3.1. > > PR: 215649 > MFC after: 3 days Hi, I don't know if it's this commit, but there is now an assertion failure when trying to build lang/spidermonkey24 (It was building fine with base/head@312672) http://beefy12.nyi.freebsd.org/data/head-amd64-default/p432463_s312786/logs/errors/spidermonkey24-24.2.0_4.log Cheers, Antoine