From owner-freebsd-new-bus Tue Jun 27 3:11:54 2000 Delivered-To: freebsd-new-bus@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 6D99637BEFE for ; Tue, 27 Jun 2000 03:11:42 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: (qmail 22845 invoked from network); 27 Jun 2000 10:11:35 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 27 Jun 2000 10:11:35 -0000 Date: Tue, 27 Jun 2000 20:11:32 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Doug Rabson Cc: Warner Losh , new-bus@FreeBSD.ORG Subject: Re: Why can't I have.. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-new-bus@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 27 Jun 2000, Doug Rabson wrote: > On Mon, 26 Jun 2000, Warner Losh wrote: > > > > > ... a INTR_TYPE_FAST | INTR_TYPE_MISC? > > > > It gives me: > > panic("still using grody create_intr interface"); > > > > What's the deal? It is easy enough to fix the problem, but I was > > wondering why the code is still there... > > > > This is, admittedly, in -stable. > > Hmm. I thought Peter had fixed that ages ago. If you can generate patches, > I would appreciate it. I seem to have fixed it locally ages ago. diff -c2 nexus.c~ nexus.c *** nexus.c~ Mon Jun 26 17:57:09 2000 --- nexus.c Mon Jun 26 17:57:11 2000 *************** *** 399,403 **** { intrmask_t *mask; - driver_t *driver; int error, icflags; --- 411,414 ---- *************** *** 411,423 **** else icflags = INTR_EXCL; ! ! driver = device_get_driver(child); ! switch (flags) { case INTR_TYPE_TTY: mask = &tty_imask; - break; - case (INTR_TYPE_TTY | INTR_TYPE_FAST): - mask = &tty_imask; - icflags |= INTR_FAST; break; case INTR_TYPE_BIO: --- 422,430 ---- else icflags = INTR_EXCL; ! if (flags & INTR_TYPE_FAST) ! icflags |= INTR_FAST; ! switch (flags & ~INTR_TYPE_FAST) { case INTR_TYPE_TTY: mask = &tty_imask; break; case INTR_TYPE_BIO: Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-new-bus" in the body of the message