Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Nov 2024 19:13:05 -0700
From:      Colin Percival <cperciva@freebsd.org>
To:        Ravi Pokala <rpokala@freebsd.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs
Message-ID:  <a698a48d-7ec9-4fce-a98d-f9955c5ed37e@freebsd.org>
In-Reply-To: <6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2@panasas.com>
References:  <202410312247.49VMl6TW031342@gitrepo.freebsd.org> <6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2@panasas.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11/1/24 18:34, Ravi Pokala wrote:
> This seems to have broken arm64.LINT-FDT:
> 
> ================================================================
> % less _.arm64.LINT-FDT
> ...
> --------------------------------------------------------------
>>>> stage 3.1: building everything
> --------------------------------------------------------------
> In file included from /usr/home/rpokala/freebsd/src/clean-main/sys/dev/gpio//gpioaei.c:37:
> /usr/home/rpokala/freebsd/src/clean-main/sys/dev/acpica/acpivar.h:34:10: fatal error: 'acpi_if.h' file not found
>     34 | #include "acpi_if.h"
>        |          ^~~~~~~~~~~
> 1 error generated.
> *** [gpioaei.o] Error code 1
> 
> make[8]: stopped making "all" in /usr/home/rpokala/freebsd/src/clean-main/sys/modules/gpio/gpioaei

Oops.  It was probably the earlier commit which broke it, but I'm clearly
not good at kernel modules.

Can you check if adding "acpi_if.h" to SRCS in
   src/sys/modules/gpio/gpioaei/Makefile
fixes the problem?

-- 
Colin Percival
FreeBSD Release Engineering Lead & EC2 platform maintainer
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a698a48d-7ec9-4fce-a98d-f9955c5ed37e>