Date: Fri, 08 Jun 2018 09:27:36 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck Message-ID: <bug-227109-7788-77Vow97jx0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227109 --- Comment #25 from commit-hook@freebsd.org --- A commit references this bug: Author: mat Date: Fri Jun 8 09:26:39 UTC 2018 New revision: 471993 URL: https://svnweb.freebsd.org/changeset/ports/471993 Log: SC2035: Use ./*glob* or -- *glob* so names with dashes won't become optio= ns. Since files and arguments are strings passed the same way, programs can't properly determine which is which, and rely on dashes to determine what's what. A file named -f (touch -- -f) will not be deleted by the problematic code. It will instead be interpreted as a command line option, and rm will even report success. Using ./* will instead cause the glob to be expanded into ./-f, which no program will treat as an option. It is not possible to use `-f *` because -f only forces the next argument to be a directory, a later directory named -delete would mess things up. PR: 227109 Submitted by: mat Sponsored by: Absolight Changes: head/Mk/Scripts/smart_makepatch.sh --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227109-7788-77Vow97jx0>