From owner-cvs-all  Thu May 31  5:57: 2 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id B689437B424; Thu, 31 May 2001 05:56:57 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA08718;
	Thu, 31 May 2001 22:56:55 +1000
Date: Thu, 31 May 2001 22:55:20 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: FUJISHIMA Satsuki <sf@FreeBSD.org>
Cc: Warner Losh <imp@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src UPDATING
In-Reply-To: <8666eil46i.wl@cheerful.com>
Message-ID: <Pine.BSF.4.21.0105312231160.25702-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, 31 May 2001, FUJISHIMA Satsuki wrote:

> I wonder why some Makefile's under src/ use ${INSTALL} -c directly
> rather than ${COPY}. If there isn't a special reason to do so, I would
> like to replace them with ${COPY}.
> ...
> M etc/Makefile
> M etc/isdn/Makefile
> ...

They do this because ${COPY} gives the user's preference for copying
files.  Honoring the user's preference for copying in these Makefiles
would have been just a bug in these Makefiles, since the valid preference
of COPY="" would have deleted source files.  -c should be used instead
of copy precisely for installing source files.

-c is now the default for install(1), so both -c and ${COPY} have no
effect unless ${COPY} is abused for something other than the user's
preference for copying.

I think the correct fix is to remove all instances of -c and COPY.  COPY
is a FreeBSD thing.  It was added by rgrimes in FreeBSD-1.x.  The .mk
files in 4.4BSD-Lite2 use plain "install" for most generated files, so
the default in 4.4BSD-Lite2 was to remove most generated files after
installing them.  I think the default for COPY was always -c in FreeBSD,
and the only reason to have a macro for this was to support bug for bug
compatible behaviour.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message