From owner-freebsd-fs@freebsd.org  Mon Jun 29 17:40:05 2015
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE686990A89
 for <freebsd-fs@mailman.ysv.freebsd.org>; Mon, 29 Jun 2015 17:40:05 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AB2CF1E4B
 for <freebsd-fs@FreeBSD.org>; Mon, 29 Jun 2015 17:40:05 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5THe5MH058284
 for <freebsd-fs@FreeBSD.org>; Mon, 29 Jun 2015 17:40:05 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-fs@FreeBSD.org
Subject: [Bug 168158] [zfs] incorrect parsing of sharenfs options in zfs
 (fsshare.c)
Date: Mon, 29 Jun 2015 17:40:05 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: eborisch+FreeBSD@gmail.com
X-Bugzilla-Status: In Progress
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc attachments.created
Message-ID: <bug-168158-3630-uflssOsrbR@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-168158-3630@https.bugs.freebsd.org/bugzilla/>
References: <bug-168158-3630@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2015 17:40:05 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168158

eborisch+FreeBSD@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eborisch+FreeBSD@gmail.com

--- Comment #3 from eborisch+FreeBSD@gmail.com ---
Created attachment 158168
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158168&action=edit
Patch to support hyphenated host names in sharenfs zfs property.

Simple patch that only ignores leading hyphens in options.

With this change:

    '-ro,a-server -alldirs' -> '-ro a-server -alldirs'

instead of (current behavior):

    '-ro,a-server -alldirs' -> '-ro a server -alldirs'

Changed by removing '-' from strsep() call, and handling (skipping) hyphen if
first character immediately after strsep() call.

All test cases listed immediately prior to the code still work; I'm not aware
of any supported forms that are broken by this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.