From owner-svn-ports-all@freebsd.org Wed Oct 19 07:46:53 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EDAAC17A8A; Wed, 19 Oct 2016 07:46:53 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-yb0-f172.google.com (mail-yb0-f172.google.com [209.85.213.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A71C0F8D; Wed, 19 Oct 2016 07:46:52 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-yb0-f172.google.com with SMTP id 184so6148373yby.2; Wed, 19 Oct 2016 00:46:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tTzJPgzOyjLfel77IWwvOsaKn98413wk+I9PRnVkk6E=; b=CzVdrUsDi+VpifAxjzE1J1jTnS8raSqOJhDpoNB5YQTNIXutK4hMpZ52WEOhw2YbCb KcBh5CAzQzNV0+/QGL0L2GhrEplw1mBlKAiy4Z6FnUVFva/KHbB6uPYJg5/OZnvaelG/ t2u2UPzTa1wl8FiPe6LzCjwMGkhF/9Kqi+am5CFNO/FVl6ynIRvB8wTFXNVLeHmtEH5p MRz+Zz8pnXBPLJwMpnbM2XdCdN7Nf1EX0/conWqk/CwYj9nRMglPF+Ty4m9suu0IfXoV kD4MuXLIDVTKomCG7vy3IlA3z3VZdYCL2V5v29oL5DQflBGH/dqYI8gNXBwXTLVJQWOY B8vg== X-Gm-Message-State: AA6/9RmO2YBVGUaQg3glgAHpJpKSO26ZgiZtWx5GhMt8YPinLxgAi/Y9Wq97QE/fuBa5pg== X-Received: by 10.37.221.129 with SMTP id u123mr4533812ybg.61.1476862901618; Wed, 19 Oct 2016 00:41:41 -0700 (PDT) Received: from mail-yb0-f177.google.com (mail-yb0-f177.google.com. [209.85.213.177]) by smtp.gmail.com with ESMTPSA id z133sm15274553ywb.51.2016.10.19.00.41.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 00:41:41 -0700 (PDT) Received: by mail-yb0-f177.google.com with SMTP id f97so1005188ybi.1; Wed, 19 Oct 2016 00:41:41 -0700 (PDT) X-Received: by 10.37.170.37 with SMTP id s34mr4569924ybi.78.1476862901096; Wed, 19 Oct 2016 00:41:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.252.129 with HTTP; Wed, 19 Oct 2016 00:41:40 -0700 (PDT) In-Reply-To: <73BDBF7D-18B3-46DB-96E1-977A5580BE8C@adamw.org> References: <201610181722.u9IHMa0t093801@repo.freebsd.org> <73BDBF7D-18B3-46DB-96E1-977A5580BE8C@adamw.org> From: "Tobias C. Berner" Date: Wed, 19 Oct 2016 09:41:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r424182 - in head: Mk Mk/Uses accessibility/jovie accessibility/kaccessible accessibility/kmag accessibility/kmousetool accessibility/kmouth archivers/ark astro/kstars astro/marble audi... To: Adam Weinberger Cc: "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 07:46:53 -0000 Hi The virtual categories themselves like kde-kde4, kde-frameworks (~70 ports), kde-plasma (~40 ports), kde-applications (~200 ports) make sense themselves, as they have more ports than some non-virtual ones, and nicely group the KDE ports some more into what upstream ships. The only thing we do here, is doing something useful with the value of CATEGORIES. There is no unexpected behaviour, as the values are not overwritten. And the magic is still enabled by USES. USES=kde:[45] enables the magic. The change to bsd.port.mk is has no meaning unless kde:[45] is used. The magic just peaks at CATEGORIES to decide what to do. mfg Tobias On 19 October 2016 at 08:12, Adam Weinberger wrote: > > On 18 Oct, 2016, at 11:22, Tobias C. Berner > wrote: > > > > Author: tcberner > > Date: Tue Oct 18 17:22:35 2016 > > New Revision: 424182 > > URL: https://svnweb.freebsd.org/changeset/ports/424182 > > > > Log: > > Introduce new extensible virtual categories for KDE > > > > A lot of KDE Ports share MASTERSITES, LICENSE and so one, as they are > > released as a bundle upstream, however, there was not really a clean > > way to share this information. > > > > Using these new categories, we can simplify the Makefiles for the > diverse > > KDE ports. > > At the moment we support the virtual category > > * kde-kde4 > > In the future, this will be extended to > > * kde-frameworks > > * kde-plasma > > * kde-applications > > > > PR: 213406 > > Differential Revision: https://reviews.freebsd.org/D7645 > > Exp-run by : antoine > > Reviewed by: mat, rakuco > > Approved by: portmgr (mat), rakuco (mentor) > > > > I hate to be that guy, but.... > > Are you sure that turning category into a magical setting is the best way > to go? Category has never been magical before, and it sets a whole new > precedent (until now, "Why aren't my distfiles showing up where I expect?" > has never been answered with "CATEGORY"). > > Wouldn't something like > USES= kde:dist-kde4 > be a more predictable way of doing this? > > USES enables magic. CATEGORY sets the category. Do we really want to > change that? > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > http://www.adamw.org > >