From owner-cvs-all Sun Apr 2 16:13:12 2000 Delivered-To: cvs-all@freebsd.org Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by hub.freebsd.org (Postfix) with ESMTP id 347F237B58F; Sun, 2 Apr 2000 16:13:04 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id IAA42093; Mon, 3 Apr 2000 08:42:50 +0930 (CST) Date: Mon, 3 Apr 2000 08:42:50 +0930 From: Greg Lehey To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Danish axes (was: cvs commit: src/sys/alpha/alpha machdep.c src/sys/cam/scsi scsi_cd.c scsi_da.c scsi_pass.c scsi_pt.c scsi_sa.c scsi_target.c src/sys/contrib/dev/fla fla.c src/sys/contrib/softupdates ffs_softdep.c src/sys/dev/amr amr.c amr_disk.c src/sys/dev/ata ...) Message-ID: <20000403084250.A41843@freebie.lemis.com> References: <200004021524.IAA02434@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <200004021524.IAA02434@freefall.freebsd.org> WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sunday, 2 April 2000 at 8:24:58 -0700, Poul-Henning Kamp wrote: > phk 2000/04/02 08:24:58 PDT > > sys/dev/vinum vinuminterrupt.c vinumio.c vinumraid5.c > vinumrequest.c vinumrevive.c > vnode_pager.c > Log: > Move B_ERROR flag to b_ioflags and call it BIO_ERROR. > > (Much of this done by script) > > Move B_ORDERED flag to b_ioflags and call it BIO_ORDERED. > > Move b_pblkno and b_iodone_chain to struct bio while we transition, they > will be obsoleted once bio structs chain/stack. > > Add bio_queue field for struct bio aware disksort. Is this another night of the Danish axes? You know that we have serious problems with Vinum already, and a number seem to stem from your last changes. You didn't even pass this by me. How do you expect me to fix anything when you keep moving the target? If you want to make these changes yourself, at least test the results and ensure that all known problems have been removed. I think we should add an item to the policy that changes of this magnitude should only be done with consensus. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message