From owner-svn-src-all@freebsd.org Fri Apr 5 04:49:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D066415698D4; Fri, 5 Apr 2019 04:49:35 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 328ED75344; Fri, 5 Apr 2019 04:49:34 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x354nVrH036897; Thu, 4 Apr 2019 21:49:31 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x354nUEC036896; Thu, 4 Apr 2019 21:49:30 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs In-Reply-To: <201904050221.x352LGjU015040@repo.freebsd.org> To: Xin LI Date: Thu, 4 Apr 2019 21:49:30 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 328ED75344 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.76 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.76)[-0.759,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 04:49:36 -0000 > Author: delphij > Date: Fri Apr 5 02:21:16 2019 > New Revision: 345900 > URL: https://svnweb.freebsd.org/changeset/base/345900 > > Log: > Implement checking of `.' and `..' entries of subdirectory. > > Reviewed by: pfg > Obtained from: Android https://android.googlesource.com/platform/external/fsck_msdos/+/b6ee08aadb580341a4d80943741b80de16a88b5d%5E%21/ > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D19824 > > Modified: > head/sbin/fsck_msdosfs/dir.c > > Modified: head/sbin/fsck_msdosfs/dir.c > ============================================================================== > --- head/sbin/fsck_msdosfs/dir.c Fri Apr 5 01:22:30 2019 (r345899) > +++ head/sbin/fsck_msdosfs/dir.c Fri Apr 5 02:21:16 2019 (r345900) > @@ -444,7 +444,78 @@ checksize(struct bootblock *boot, struct fatEntry *fat > return FSOK; > } > > +static const u_char dot_name[] = { > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > +static const u_char dotdot_name[] = { > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > + Does it make since to encode these as hex or octal constants, one can not tell that those are different values in an easy manner. They all look like '.' in the diff, and probably in most editors. > /* ... -- Rod Grimes rgrimes@freebsd.org