From nobody Thu Mar 26 01:28:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fh5lL2SR0z6X5K9 for ; Thu, 26 Mar 2026 01:28:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fh5lL1klMz3SM2 for ; Thu, 26 Mar 2026 01:28:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774488526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1kJ43XqtHPYfN9joVcZN4nwlTu9atQR4PUZAz2dS/So=; b=kD3uJQ/7/nhMHYmq/H1g8WY6XBWYyuHALNbX2YsbJro7NzVolJVDuf0XDxsIQLzzBkfnI3 Rhzdd5WFDkZSQ0TjT6TqtxHuWtsxbzzdGhItYIwSC8Tj48u8F/8ppCdFWdY6Q/uZzJiPxv qrIC1vIzLOu53jqSmKYAs4cbHPm3kkRgMMbtxWsNLKvDdq3Kk1ijeW1JRrgAnJte+4z4Uv 7mmTWokumGtuy9p+k1oradCE4rqcW100YpNN4zd0rBuLpzE2a4sa5Nt9b5Mwiuovt9SEX6 LromvjsQ2qkAwO3McZxpUGhzfK0UmbKpIY5rd/hI1aA3dWsND/DOnAyazxhh5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774488526; a=rsa-sha256; cv=none; b=SJUOIxYamhwgSxlCvBVhv2ZQIlkOOXNMvpHkC6uGWP+QMNymnP8ugUIopnsD3uvHOavhbF yD/VjLxDK7RSWpJEZvHWsXAWgZI3j2PS1yxx6YBkl279thbF58J6kFoLG9GgQ+LViuT9AR iPVbW6PpGclIVszphle9gc5mTHqOb88Ah9/bH1DGyZk38fqWMUe4GTAmK2NbQ19m/mdzNT eQ6TBJTrF1q8yIqtm/EM989pR7KgvJXu7ViL9Pd9XwswGf9+kCshTAv6sfSfQaILKURBaf l4CdBJoei56oW34yb3P2VdSUODtnMoS93hnNedE6SsNGJjRMtxWPJU9rJSn2ZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774488526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1kJ43XqtHPYfN9joVcZN4nwlTu9atQR4PUZAz2dS/So=; b=NsxzTmIFtXtkedmH8Xdc8TymqkXUYSfnzoFmUpjIG77JeR3J0RCb7YApHjeFnB+MPUzjq3 wDQoQXfIxZk+rQrvxCbmPeWwWcUR9FpfzHnLD6hrcmncICFR2i9wPWA+ANuiFmT+/31g/+ WJ78nCxDfUDVBQblDE/QOYw+QAea3ZOOcVjBuR9Emw882dveePRORH1zhugonsgmiD2W9U N30Ne+RZMe/4VkHwfnM0E2fzJtuH2Bgi/XXC63JogcIdGDja7K9Rv6ebJCRANBM3e9hPyE VjcmEJQbg3nv0f0IfaLH0i5pUSxkd/x6Yk8YAkFbUYcLurndFl2Q4MPEN8KFNQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fh5lL0xHxzVl9 for ; Thu, 26 Mar 2026 01:28:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 191c3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 01:28:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Michael Tuexen From: Gordon Tetlow Subject: git: b45e7530ffb9 - stable/14 - tcp: plug an mbuf leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b45e7530ffb92fbaa24ad25c368479d4eb80dbf4 Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 01:28:46 +0000 Message-Id: <69c48bce.191c3.69ca1884@gitrepo.freebsd.org> The branch stable/14 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=b45e7530ffb92fbaa24ad25c368479d4eb80dbf4 commit b45e7530ffb92fbaa24ad25c368479d4eb80dbf4 Author: Michael Tuexen AuthorDate: 2026-03-25 05:53:56 +0000 Commit: Gordon Tetlow CommitDate: 2026-03-26 01:28:29 +0000 tcp: plug an mbuf leak When a challenge ACK should be sent via tcp_send_challenge_ack(), but the rate limiter suppresses the sending, free the mbuf chain. The caller of tcp_send_challenge_ack() expects this similar to the callers of tcp_respond(). Approved by: so Security: FreeBSD-SA-26:06.tcp Security: CVE-2026-4247 Reviewed by: lstewart Tested by: lstewart Sponsored by: Netflix, Inc. (cherry picked from commit 6b2d6ccad2552e46a5c9c3ba70b2d0ed27c70ca8) --- sys/netinet/tcp_subr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 81b378f496c9..32c30dc4d067 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2276,6 +2276,8 @@ tcp_send_challenge_ack(struct tcpcb *tp, struct tcphdr *th, struct mbuf *m) tcp_respond(tp, mtod(m, void *), th, m, tp->rcv_nxt, tp->snd_nxt, TH_ACK); tp->last_ack_sent = tp->rcv_nxt; + } else { + m_freem(m); } }