From nobody Tue Jan 14 14:43:47 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YXX1w5DRGz5km4y; Tue, 14 Jan 2025 14:43:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YXX1w03q1z3gtM; Tue, 14 Jan 2025 14:43:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736865828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0hP3TsQ2S9q3guyrU4ztBs0m2MWb2SaaMAp2kv9DguA=; b=J8EhLW8eqpNCqoUevfTgzZouHBcO9Bh/76gJSY/ORWhHh26lILmMJ0gGdgLXKMkjz5NvFl gGVTtppOPjSbxwVZJ3BJCPOcMkJGcct5FCQJON+2YI+qAhS0eaHNWgoD28PWz8ye2jH1WG oLU/9EYRNnqREeexDTCMWt2SoLR9qxvsWbwBbMFXiGB8KNs3zmVZyymzm/QE9iT8uPu8Of ZmvdNzTNsTEoExiXB4tF2vsgOjrtzlfbnfIpNxLa0y/0hPVL/s/kvJo1YwjJMTJyxbSeC9 cpqZZc+2AzOAXL/JmANnMyNkR9ehWgpVqG9DEbs9Y+Ggftomu7ajtQQMoaSwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736865828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0hP3TsQ2S9q3guyrU4ztBs0m2MWb2SaaMAp2kv9DguA=; b=eC5BUlfcedRXmCJgjqWGQWgUUNhdeOiS6ftMVbRUqf19hxtMtb6gtGPPMvCYa0+iB8EBkd z/j+/bs27sTGv7jNak988H1zOHV2Kb+UBdwdjbo9YSXSnF+9OwQw7QX4f0gmqIhQR6Iww1 Cem2wtxG/3acOT/Ok6lIzwZdSp1PHELnOuiDwEkirjGSJhVl9D45MElYFxiyBpuyhmRAcT lxdolwFtdl/PGWQSAnMEpeIFVqSHwnnDHTZk4+ZBQ+1FQEZHlTI5pA1H49UkRBh/3llrVl 4Fwv9w6Hx7OBWcCRxPrOzwToxf+dGTU8FCcN5Oeh4L/zQYP2oHeJJL55GgnGzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736865828; a=rsa-sha256; cv=none; b=AidPMJRuZ24gO0aKBt5OBlRCgnxY6TzSkcip2qUetahPgLo7RF16RMB8U6avlurZEQIAx6 tWLLfGHjpxayAAsEL0Ge3bgKbd5nhdavhzqOQoT9qbnnvvGcub3Mfu4lp4GIDxsAZ/VoqI bv4gtYKN1i3C4vGqgKkur1+bYViQTslodNox+b6dnNrnxLBFItcrSoosnnPShjP6zvjZ6R g/Xj7Qe+z081agObLJjamNxy7kDsNs4q6TC2JqfFzKMrdGUTL38Ggcl17lgGIDpB/jh5Jc 9eRvi/tY969LyosWCOuXLo3O9PIyOs9bwzvyvsDcSLabWqUn5KoPutinEK50Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YXX1v6nLTz1Kb8; Tue, 14 Jan 2025 14:43:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50EEhlxY014733; Tue, 14 Jan 2025 14:43:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50EEhlgw014730; Tue, 14 Jan 2025 14:43:47 GMT (envelope-from git) Date: Tue, 14 Jan 2025 14:43:47 GMT Message-Id: <202501141443.50EEhlgw014730@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 40c01de13562 - stable/13 - x86: Short-circuit ipi_all_but_self() on UP systems List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 40c01de1356224a82fec217bd3cd59dd058ef095 Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=40c01de1356224a82fec217bd3cd59dd058ef095 commit 40c01de1356224a82fec217bd3cd59dd058ef095 Author: Mark Johnston AuthorDate: 2025-01-07 17:58:58 +0000 Commit: Mark Johnston CommitDate: 2025-01-14 14:14:45 +0000 x86: Short-circuit ipi_all_but_self() on UP systems Apparently this is required on old intel hw, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275086#c3 PR: 275086 Reviewed by: mav, kib Fixes: 279cd05b7e4d ("Use APIC_IPI_DEST_OTHERS for bitmapped IPIs too.") MFC after: 1 week Diagnosed by: Ben Wilber Differential Revision: https://reviews.freebsd.org/D48361 (cherry picked from commit 254a2b767f9a39f1541e0a07a70bbe269e86ad70) --- sys/x86/x86/mp_x86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/mp_x86.c b/sys/x86/x86/mp_x86.c index 56cf7e426076..771cf95f36b4 100644 --- a/sys/x86/x86/mp_x86.c +++ b/sys/x86/x86/mp_x86.c @@ -1424,6 +1424,9 @@ ipi_all_but_self(u_int ipi) cpuset_t other_cpus; int cpu, c; + if (mp_ncpus == 1) + return; + /* * IPI_STOP_HARD maps to a NMI and the trap handler needs a bit * of help in order to understand what is the source.