From nobody Wed Sep 17 12:18:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cRd9F4TWHz67Hcd; Wed, 17 Sep 2025 12:18:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cRd9F0fL9z3VLg; Wed, 17 Sep 2025 12:18:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U3YccrcxqXmIK9tgvg/TXyV5HghQsNGmHJZF3nXAwWA=; b=Yon3ubBu9bynOzY1v/P1g9fgcyzAGhGWLvZgQV1cGAi1BDJDZb8ymsSuajEYrqYdDgkQTa gJ2FPvrPzeSaLvOPi8jEJrxoi/Z408Z82EmT1nzb1N9TucnxVHVgDsrfi8be6P9g1R1Rx0 hw/n2XYQC2Xf8fyUceijxngOvewLBWOR3NTffktfJJFaouGqImoDHmGg5p3meeh2iXypWz CvY3l9qmSbc5EZPDtO+++OGZ20I3V5KIMUskiY+8hhb6YHm8C32Ipk0hAplN4w+jX3HYm6 z9bP1AySmJclYmInMh6WiP+BJV9XYx6lQ0UkoBWuh0cWinuQGsmKDoV2xPhsdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U3YccrcxqXmIK9tgvg/TXyV5HghQsNGmHJZF3nXAwWA=; b=xbuoas4j53Jzyh5GgRVHKP182vdjZLQ9q/R2NKLDAUrL23cJbMvQ89cKca+oOzaPlPjCie JDn/qdXWTnmgPK9nRtMzx77k1I/WmrrJ23k8xvX1whAUpgV9ZUGm/mby0D3NdoH5QroCns y+t/9jf/NIcpUJOYvRodAoxp4je236N/qiJwc/F+2IvmKEmq24I7a7MOj17G+X71A0KTLP X6fRNG3AuQvFRDp9Jus8Lae4K/bIYbWa4gq5qa/Ar/JoVDY5CV27YDTfWNy4muD+val82+ d2giQDsb+MHHnkpgeBAy6YTsfmXNY80AHb5VZ/E1a057jIXPOI/Rbt8DosvFXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758111537; a=rsa-sha256; cv=none; b=cV9XmeAJjHwQ9UC3LtWiKw0kfKLYPVy6GWBihmi/46oIEryE8q7LEEt8+D0ebyOvHeS/Gm ABU0Jmdh9GILo4OJ+ussk+WxpKe0nqDc/dTWnv1nDFBXJUJ4DcZPXYj8Tyg7HL01/7kci2 d2oC2aGsnKHWzeGnSY5KL7LKHqi6lS2Q0F/xfLe7uV+FYhWh4pXzaKz0HeAjbNmK5AChCm XhF3liYUnra4cIYXxXsPQNLGPMx9Y0BM0AyWWKdZgIw2/tpjG4Ol/Tw2etWy+QMu0qaqtw +d6wsQ1aGBU7RO9XR5MfNrMU+Q9nTCaqduX9gajPkqp0ur3W9DxSNxcJAZinqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cRd9F00Y8z9G4; Wed, 17 Sep 2025 12:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58HCIuJN085486; Wed, 17 Sep 2025 12:18:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58HCIuad085483; Wed, 17 Sep 2025 12:18:56 GMT (envelope-from git) Date: Wed, 17 Sep 2025 12:18:56 GMT Message-Id: <202509171218.58HCIuad085483@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 5fa6ca8b8aff - main - nfsd: nfsd_excred(): Remove an obsolete comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5fa6ca8b8affc8d948687c4ede7aeed297ae2dc0 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=5fa6ca8b8affc8d948687c4ede7aeed297ae2dc0 commit 5fa6ca8b8affc8d948687c4ede7aeed297ae2dc0 Author: Olivier Certner AuthorDate: 2025-08-27 13:40:42 +0000 Commit: Olivier Certner CommitDate: 2025-09-17 12:16:01 +0000 nfsd: nfsd_excred(): Remove an obsolete comment This comment has been obsoleted by commit be1f7435ef21 ("kern: start tracking cr_gid outside of cr_groups[]."). No functional change. MFC after: 5 days MFC to: stable/15 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52264 --- sys/fs/nfsserver/nfs_nfsdport.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index 7040c4afb797..5ba86314ead1 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -3478,11 +3478,6 @@ nfsd_excred(struct nfsrv_descript *nd, struct nfsexstuff *exp, (nd->nd_flag & ND_AUTHNONE) != 0) { nd->nd_cred->cr_uid = credanon->cr_uid; nd->nd_cred->cr_gid = credanon->cr_gid; - /* - * 'credanon' is already a 'struct ucred' that was built - * internally with calls to crsetgroups_and_egid(), so - * we don't need a fallback here. - */ crsetgroups(nd->nd_cred, credanon->cr_ngroups, credanon->cr_groups); } else if ((nd->nd_flag & ND_GSS) == 0) {