From owner-svn-src-head@FreeBSD.ORG  Sun Jan 17 21:00:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5250D1065672;
	Sun, 17 Jan 2010 21:00:30 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 431C78FC1B;
	Sun, 17 Jan 2010 21:00:30 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o0HL0U8i044497;
	Sun, 17 Jan 2010 21:00:30 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o0HL0UZv044495;
	Sun, 17 Jan 2010 21:00:30 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <201001172100.o0HL0UZv044495@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Sun, 17 Jan 2010 21:00:30 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r202527 - head/lib/libc/gen
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Jan 2010 21:00:30 -0000

Author: ed
Date: Sun Jan 17 21:00:29 2010
New Revision: 202527
URL: http://svn.freebsd.org/changeset/base/202527

Log:
  Add forgotten break; keyword to getutxid().
  
  We should not fall through to the ut_id comparison. Only ut_type should
  be compared when using OLD_TIME, NEW_TIME, BOOT_TIME or SHUTDOWN_TIME.

Modified:
  head/lib/libc/gen/getutxent.c

Modified: head/lib/libc/gen/getutxent.c
==============================================================================
--- head/lib/libc/gen/getutxent.c	Sun Jan 17 21:00:28 2010	(r202526)
+++ head/lib/libc/gen/getutxent.c	Sun Jan 17 21:00:29 2010	(r202527)
@@ -164,6 +164,7 @@ getutxid(const struct utmpx *id)
 		case SHUTDOWN_TIME:
 			if (fu->fu_type == id->ut_type)
 				goto found;
+			break;
 		case USER_PROCESS:
 		case INIT_PROCESS:
 		case LOGIN_PROCESS:
@@ -177,6 +178,7 @@ getutxid(const struct utmpx *id)
 				    MIN(sizeof fu->fu_id, sizeof id->ut_id)) == 0)
 					goto found;
 			}
+			break;
 		}
 	}