From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 9 03:10:37 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6FB6116A41F for ; Fri, 9 Jun 2006 03:10:37 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B71F43D78 for ; Fri, 9 Jun 2006 03:10:28 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k593APL3089966 for ; Fri, 9 Jun 2006 03:10:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k593APCK089965; Fri, 9 Jun 2006 03:10:25 GMT (envelope-from gnats) Resent-Date: Fri, 9 Jun 2006 03:10:25 GMT Resent-Message-Id: <200606090310.k593APCK089965@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rick van der Zwet Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A665916A41B for ; Fri, 9 Jun 2006 03:03:51 +0000 (UTC) (envelope-from rick@wzoeterwoude.net) Received: from smtp-vbr12.xs4all.nl (smtp-vbr12.xs4all.nl [194.109.24.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1BB43D8D for ; Fri, 9 Jun 2006 03:03:49 +0000 (GMT) (envelope-from rick@wzoeterwoude.net) Received: from traffie.wzoeterwoude.net (rvdzwet.xs4all.nl [213.84.99.45]) by smtp-vbr12.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5933f0S038174 for ; Fri, 9 Jun 2006 05:03:49 +0200 (CEST) (envelope-from rick@wzoeterwoude.net) Received: (qmail 98306 invoked by uid 98); 9 Jun 2006 03:03:38 -0000 Received: from 192.168.0.19 by traffie.wzoeterwoude.net (envelope-from , uid 82) with qmail-scanner-1.25 (spamassassin: 3.1.1. Clear:RC:1(192.168.0.19):. Processed in 0.537998 secs); 09 Jun 2006 03:03:38 -0000 Received: from unknown (HELO ?192.168.0.19?) (rick@192.168.0.19) by traffie.wzoeterwoude.net with SMTP; 9 Jun 2006 03:03:35 -0000 Message-Id: <4488E509.4020606@wzoeterwoude.net> Date: Fri, 09 Jun 2006 05:03:37 +0200 From: Rick van der Zwet To: FreeBSD-gnats-submit@FreeBSD.org Cc: rick@wzoeterwoude.net Subject: misc/98734: [Patch] /etc/rc.subr restart_postcmd is failing start_postcmd executed instead X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Rick van der Zwet List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2006 03:10:37 -0000 >Number: 98734 >Category: misc >Synopsis: [Patch] /etc/rc.subr restart_postcmd is failing start_postcmd executed instead >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 09 03:10:24 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rick van der Zwet >Release: FreeBSD 6.1-STABLE i386 >Organization: Stichting Wireless Leiden >Environment: System: FreeBSD freezone-mobile 6.1-STABLE FreeBSD 6.1-STABLE #8: Wed Jun 7 00:37:44 CEST 2006 root@freezone-mobile:/usr/obj/usr/src/sys/SONY_VAIO i386 >Description: instead of excecuting restart_postcmd it issues start_postcmd again >How-To-Repeat: create foe.sh . /etc/rc.subr name='foe' foe_enable="yes" rcvar=`set_rcvar` start_postcmd="echo 'foo'" restart_postcmd="echo 'bar'" run_rc_command "$1" execute sh foe.sh restart, output will be foo foo >Fix: --- rc.subr.diff begins here --- --- rc.subr.orig Fri Jun 9 04:50:16 2006 +++ rc.subr Fri Jun 9 04:50:36 2006 @@ -776,7 +776,7 @@ # run stop in a subshell to keep variables for start ( run_rc_command ${_rc_prefix}stop $rc_extra_args ) - run_rc_command ${_rc_prefix}start $rc_extra_args + ( run_rc_command ${_rc_prefix}start $rc_extra_args ) if [ -n "$_postcmd" ]; then eval $_postcmd $rc_extra_args --- rc.subr.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: