From owner-svn-src-head@FreeBSD.ORG Sat Jun 12 15:29:46 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F4FE1065677; Sat, 12 Jun 2010 15:29:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 0C8A68FC16; Sat, 12 Jun 2010 15:29:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o5CFS7gt009698; Sat, 12 Jun 2010 09:28:07 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 12 Jun 2010 09:28:09 -0600 (MDT) Message-Id: <20100612.092809.322386357415738459.imp@bsdimp.com> To: raj@semihalf.com From: "M. Warner Losh" In-Reply-To: References: <201006091957.o59JvKbu025122@svn.freebsd.org> <20100610.092502.72112000528403516.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, rdivacky@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r208964 - in head: . etc/mtree lib share/mk usr.bin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 15:29:46 -0000 In message: Rafal Jaworowski writes: : : On 2010-06-10, at 17:25, M. Warner Losh wrote: : : > In message: <201006091957.o59JvKbu025122@svn.freebsd.org> : > Roman Divacky writes: : > : Modified: head/share/mk/bsd.own.mk : > : ============================================================================== : > : --- head/share/mk/bsd.own.mk Wed Jun 9 19:32:20 2010 (r208963) : > : +++ head/share/mk/bsd.own.mk Wed Jun 9 19:57:20 2010 (r208964) : > : @@ -288,6 +288,18 @@ _no_fdt= FDT : > : .endif : > : : > : # : > : +# Default behaviour of MK_CLANG depends on the architecture. : > : +# : > : +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \ : > : + ${MACHINE_ARCH} == "powerpc" : > : +_clang_yes=CLANG : > : +_clang_no= : > : +.else : > : +_clang_yes= : > : +_clang_no=CLANG : > : +.endif : > : > We really should *NOT* be encoding architecture stuff like this into : > bsd.own.mk. Sometimes the right thing here is MACHINE_ARCH, and for : > the moment, since clang is not a bootstrap tool, this is correct. : > However, once clang is a bootstrap tool, this will be incorrect : > because during the bootstrapping for cross building TARGET_ARCH is : > what should be tested. We have the same problem with the FTD stuff : > that was recently committed. raj@ and I have been talking about the : > best ways to fix it. : : I think I'm going to drop setting WITH_FDT by default for selected : arches until the tdbemd arrives, and for this little (I hope :-) : while it will just be required for FDT-enabled platforms to specify : WITH_FDT explicitly. Yes. I think that the current WITH/WITHOUT system works well for things that are optional, like sendmail or lpt. I think it doesn't work well to specify intrinsic characteristics about a platform. That's why we're having the problems with FDT and CLANG. They are trying to specify a property of a platform by turning an optional component on or off. We've traditionally not done that, but instead have controlled this via Makefile ifdefs. I'm transitioning the latter to provide better separation.... Warner