From owner-freebsd-bugs@freebsd.org Tue Jan 3 23:15:38 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A9E9C9D628 for ; Tue, 3 Jan 2017 23:15:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D62F511E2 for ; Tue, 3 Jan 2017 23:15:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v03NFbhP017539 for ; Tue, 3 Jan 2017 23:15:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 215747] [patch] kldstat: align hex sizes to the right Date: Tue, 03 Jan 2017 23:15:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: grunk@pestilenz.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 23:15:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215747 Bug ID: 215747 Summary: [patch] kldstat: align hex sizes to the right Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: grunk@pestilenz.org Keywords: patch kldstat(1) outputs something like $ kldstat Id Refs Address Size Name 1 16 0xffffffff80200000 1fa7c38 kernel 2 1 0xffffffff82221000 3710 ums.ko 3 1 0xffffffff82225000 1fe5a3 zfs.ko 4 1 0xffffffff82424000 811f opensolaris.ko 5 1 0xffffffff8242d000 10582 geom_eli.ko I can not see the advantage of the "Size" column being aligned to the left,= but maybe I am missing something. As the code shows, the minus in the "%-8zx" modifier seems to have been entered on some purpose. However, I would think of an output like this to be more useful: $ ./kldstat Id Refs Address Size Name 1 16 0xffffffff80200000 1fa7c38 kernel 2 1 0xffffffff82221000 3710 ums.ko 3 1 0xffffffff82225000 1fe5a3 zfs.ko 4 1 0xffffffff82424000 811f opensolaris.ko 5 1 0xffffffff8242d000 10582 geom_eli.ko If this makes sense to you, please profit from the following simple patch. If not, I am sorry for the noise, and would be grateful for an explanation = why left-aligned is more helpful to the user. Index: kldstat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kldstat.c (revision 310867) +++ kldstat.c (working copy) @@ -78,7 +78,7 @@ printf("%2d %4d %p %5s %s", stat.id, stat.refs, stat.address, buf, stat.name); } else { - printf("%2d %4d %p %-8zx %s", + printf("%2d %4d %p %8zx %s", stat.id, stat.refs, stat.address, stat.size, stat.name); } } --=20 You are receiving this mail because: You are the assignee for the bug.=