From owner-freebsd-threads@FreeBSD.ORG  Fri May 30 23:05:50 2008
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0B95F1065671;
	Fri, 30 May 2008 23:05:50 +0000 (UTC)
	(envelope-from deischen@freebsd.org)
Received: from mail.netplex.net (mail.netplex.net [204.213.176.10])
	by mx1.freebsd.org (Postfix) with ESMTP id D82708FC13;
	Fri, 30 May 2008 23:05:49 +0000 (UTC)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.netplex.net (8.14.3/8.14.3/NETPLEX) with ESMTP id
	m4UN5mrA016822; Fri, 30 May 2008 19:05:48 -0400 (EDT)
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net)
X-Greylist: Message whitelisted by DRAC access database, not delayed by
	milter-greylist-4.0 (mail.netplex.net [204.213.176.10]);
	Fri, 30 May 2008 19:05:48 -0400 (EDT)
Date: Fri, 30 May 2008 19:05:48 -0400 (EDT)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200805301748.29689.jhb@freebsd.org>
Message-ID: <Pine.GSO.4.64.0805301905020.20343@sea.ntplx.net>
References: <483FA1C0.2010506@freebsd.org> <200805301748.29689.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: David Xu <davidxu@freebsd.org>, freebsd-threads@freebsd.org
Subject: Re: pthread_cleanup_push as a macro
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2008 23:05:50 -0000

On Fri, 30 May 2008, John Baldwin wrote:

> On Friday 30 May 2008 02:42:08 am David Xu wrote:
>> I would like to make pthread_cleanup_push and pthread_cleanup_pop as a
>> pair of macros, the current implementation has to malloc() and free() a
>> pthread_cleanup memory block everytime, this is slow, the new one
>> simply uses stack space, note that other OSes have already done it in
>> this way. The patch keeps old functions and should not have binary
>> compatible problem.
>>
>> http://people.freebsd.org/~davidxu/patch/pthread_cleanup_push.patch
>
> Please do!

I agree - Solaris does this too.  I am unsure why you really need
a strong_reference - I would prefer something that doesn't require
it.

-- 
DE