From owner-cvs-src@FreeBSD.ORG  Sat Jun 26 23:05:37 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3A25716A4CE; Sat, 26 Jun 2004 23:05:37 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 99E1643D41; Sat, 26 Jun 2004 23:05:36 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i5QN5XMa003323;
	Sun, 27 Jun 2004 01:05:33 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Andrey Chernov <ache@nagual.pp.ru>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 26 Jun 2004 17:51:19 +0400."
             <20040626135119.GA29134@nagual.pp.ru> 
Date: Sun, 27 Jun 2004 01:05:33 +0200
Message-ID: <3322.1088291133@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern tty.c src/sys/net if_sl.c ppp_tty.c
	src/sys/netgraph ng_tty.c src/sys/netgraph/bluetooth/drivers/h4
	ng_h4.c src/sys/sys linedisc.h tty.h 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jun 2004 23:05:37 -0000

In message <20040626135119.GA29134@nagual.pp.ru>, Andrey Chernov writes:
>On Sat, Jun 26, 2004 at 08:44:04AM +0000, Poul-Henning Kamp wrote:
>>   Fix line discipline switching issues: If opening a new ldisc fails,
>>   we have to revert to TTYDISC which we know will successfully open
>>   rather than try the previous ldisc which might also fail to open.
>
>What about trying to switch to previous ldisc first and, only if it fails, 
>revert to TTYDISC?

Why microptimize something which has always been broken ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.