From owner-svn-src-head@FreeBSD.ORG  Sat Dec 11 10:25:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 49293106566B;
	Sat, 11 Dec 2010 10:25:30 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id EF2248FC1D;
	Sat, 11 Dec 2010 10:25:28 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA20147;
	Sat, 11 Dec 2010 12:25:26 +0200 (EET) (envelope-from avg@freebsd.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1PRMdq-0007qK-Hi; Sat, 11 Dec 2010 12:25:26 +0200
Message-ID: <4D035195.9090905@freebsd.org>
Date: Sat, 11 Dec 2010 12:25:25 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6
MIME-Version: 1.0
To: Andriy Gapon <avg@freebsd.org>
References: <201012111021.oBBALcrV004450@svn.freebsd.org>
In-Reply-To: <201012111021.oBBALcrV004450@svn.freebsd.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r216375 - head/sys/mips/rmi/dev/xlr
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Dec 2010 10:25:30 -0000

on 11/12/2010 12:21 Andriy Gapon said the following:
> Author: avg
> Date: Sat Dec 11 10:21:38 2010
> New Revision: 216375
> URL: http://svn.freebsd.org/changeset/base/216375
> 
> Log:
>   fix atomic_set_xxx misuse in rge
>   
>   It seems that atomic_set_xxx and atomic_store_xxx were confused.

Please note that I've just made a mechanical change.
Most probably atomic store is not needed here at all.

>   Reviewed by:	jhb (general issue)
>   MFC after:	3 weeks
> 
> Modified:
>   head/sys/mips/rmi/dev/xlr/rge.c
> 
> Modified: head/sys/mips/rmi/dev/xlr/rge.c
> ==============================================================================
> --- head/sys/mips/rmi/dev/xlr/rge.c	Sat Dec 11 10:18:05 2010	(r216374)
> +++ head/sys/mips/rmi/dev/xlr/rge.c	Sat Dec 11 10:21:38 2010	(r216375)
> @@ -170,7 +170,7 @@ extern uint32_t cpu_ltop_map[32];
>  static int port_counters[4][8] __aligned(XLR_CACHELINE_SIZE);
>  
>  #define port_inc_counter(port, counter) 	atomic_add_int(&port_counters[port][(counter)], 1)
> -#define port_set_counter(port, counter, value) 	atomic_set_int(&port_counters[port][(counter)], (value))
> +#define port_set_counter(port, counter, value) 	atomic_store_int(&port_counters[port][(counter)], (value))
>  #else
>  #define port_inc_counter(port, counter)	/* Nothing */
>  #define port_set_counter(port, counter, value)	/* Nothing */
> @@ -2281,7 +2281,7 @@ rmi_xlr_mac_open(struct rge_softc *sc)
>  	mtx_unlock_spin(&priv->lock);
>  
>  	for (i = 0; i < 8; i++) {
> -		atomic_set_int(&(priv->frin_to_be_sent[i]), 0);
> +		atomic_store_int(&(priv->frin_to_be_sent[i]), 0);
>  	}
>  
>  	return 0;


-- 
Andriy Gapon