From owner-cvs-all  Thu Dec 13  5:17:43 2001
Delivered-To: cvs-all@freebsd.org
Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201])
	by hub.freebsd.org (Postfix) with ESMTP
	id A9E9137B41C; Thu, 13 Dec 2001 05:17:34 -0800 (PST)
Received: from sheldonh (helo=axl.seasidesoftware.co.za)
	by axl.seasidesoftware.co.za with local-esmtp (Exim 3.33 #1)
	id 16EVle-00009k-00; Thu, 13 Dec 2001 15:19:18 +0200
From: Sheldon Hearn <sheldonh@starjuice.net>
To: cvs-committers@FreeBSD.org
Cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/smbfs smbfs_vfsops.c 
In-reply-to: Your message of "Thu, 13 Dec 2001 05:08:35 PST."
             <200112131308.fBDD8Zm59173@freefall.freebsd.org> 
Date: Thu, 13 Dec 2001 15:19:18 +0200
Message-ID: <603.1008249558@axl.seasidesoftware.co.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG



On Thu, 13 Dec 2001 05:08:35 PST, Sheldon Hearn wrote:

>   Modified files:
>     sys/fs/smbfs         smbfs_vfsops.c 
>   Log:
>   Add module dependency on libmchain.
>   
>   With this change, mounting an smb share (using mount_smb, which is not
>   yet included in the tree) without any of smbfs, libiconv or libmchain
>   compiled into the kernel or loaded works.

I included <sys/module.h>, which is already included by <sys/kernel.h>.

I did this because I'm guessing it's _not_ okay to assume that
<sys/kernel.h> will include <sys/module.h>.

Am I right, or should I remove the explicit inclusion of <sys/module.h>?

Ciao,
Sheldon.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message