From owner-svn-src-all@freebsd.org Sat Sep 5 20:41:42 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EADB3D594C for ; Sat, 5 Sep 2020 20:41:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BkRKd0Yy2z3bxW for ; Sat, 5 Sep 2020 20:41:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf30.google.com with SMTP id h1so4774539qvo.9 for ; Sat, 05 Sep 2020 13:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JZE92QXsfHSBVgFF0ALH5l3ei1BuZTXSJasdEfdau68=; b=i1ZAmdaN98aNaRLbX9Ap1Sp6px1YbbEJFevq1eSuvFk0CF/5t7SLIs4ObGyNlVkPZz gBleBu+EpqkCGBbUvT44Jt1pO42Dkm7jwdjtYcrqC50rW/fcriynW+Imi6aDa7d95pD4 mutdQom68jZwAEkSYMdzHIYGFWVQ8ktmmounOI7hqRjWfnhX+WVzK0C/SrdzlCy8CejY RHg2zX05K3dvufOLZ5b8uYK+nAeMp221kcrP2/aurxZLfUTHsptBSO0MSeP1jAOVh8/8 iqGCKda8/UZ2qccyAjRcD1guHWEJV8NJ9x0wTX5Z4RmLDza81c5YSA00NsUxF6IhBxP/ 9EWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JZE92QXsfHSBVgFF0ALH5l3ei1BuZTXSJasdEfdau68=; b=XlAK8OJoxnM89HsQRYiifwfdP0vgpuozGtpfdhMDHtb1a5SjQw3npFd28DeSL0bCSY qwYAQtl+an/BWaIctc2rx0d2h/z41NhNQolwortID6z66RhsedtmxdObqSQ4IWWG5PP4 1vrZWawh5AyNFNCm+zP1l28h/rgBLW2VAdKyzVJgsJbvNifYka4TBuW/yhv/kSGdrRZO jkJMkNWXL5pNsLxke/WT3+9eL6xBKDfnYdSasXGqJhJkY1oyfHAVMjcExa3iRffW5vVR jw5t9L3vgqPHFwtS+TXkG0yfkfM0rSyTc2fEv/7mHYZ+BeAH7zZltCvULmJtY+BL1WCz DKUg== X-Gm-Message-State: AOAM532c6jz+Pe2J3Egms4BHb8mPs60BXCKOs5XL6m0KQrKCtTEaz9tE 109L2sYvsV+NDyybvKyMeRINtVwN2IRYhYaCIjKy1g== X-Google-Smtp-Source: ABdhPJwz25y2ISHnZ7k/T3ZGVdyoNlpqoJXbXV6Pq4BFB5T8clFjAwWGy1mO/NRF2M3A+va6Q24pKW3NnDfmO0jyRqg= X-Received: by 2002:a0c:e602:: with SMTP id z2mr14264021qvm.69.1599338499880; Sat, 05 Sep 2020 13:41:39 -0700 (PDT) MIME-Version: 1.0 References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> <08636D5E-AA07-4AE7-B5AC-656B08CF564B@fh-muenster.de> <20200903024226.GA54078@FreeBSD.org> <60ea593f-8258-e30d-b897-f162168b44d3@cs.duke.edu> <20200905010510.GA26297@lonesome.com> In-Reply-To: From: Warner Losh Date: Sat, 5 Sep 2020 14:41:28 -0600 Message-ID: Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... To: Ed Maste Cc: Kevin Bowling , Mark Linimon , Andrew Gallatin , Alexey Dokuchaev , Michael Tuexen , Pedro Giffuni , Mateusz Guzik , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4BkRKd0Yy2z3bxW X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=i1ZAmdaN; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f30) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.60 / 15.00]; ARC_NA(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.07)[-1.068]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.01)[-1.007]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.53)[-0.527]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f30:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Mailman-Approved-At: Sun, 06 Sep 2020 09:06:15 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2020 20:41:42 -0000 On Sat, Sep 5, 2020 at 1:42 PM Ed Maste wrote: > On Fri, 4 Sep 2020 at 23:11, Kevin Bowling > wrote: > > > > An arbitrary formater may leave a > > little bit of annoyance to each person's taste, but that is a tiny > > drop in the bucket compared to never having to discuss and especially > > correct (which may /seem/ helpful but is pretty offputting to > > newcomers). > > As an experiment I ran clang-format over an arbitrary file > (vtfontcvt.c) and put the results in > https://reviews.freebsd.org/D26340 > > Relative to the original file there are a few style(9) items that have > been fixed, a few that have been broken, and some that are arguably > worse but really indifferent. > > Fixed: > - *_FOREACH now has a space before (, equivalent to for (;;) > Except pretty much everywhere we don't have a space there... > - header sorting > - space between sizeof and ( removed > - indentation of an if body > - unwrapped function call that fits on one line > > Broken: > - indentation of if / for conditions that span 2 or more lines > broke all alignment of variables and comments that were done. broke all err() calls to wrap too much broke purposely outdented code in statistics function extra headers still included. > > Indifferent: > - lose lined-up struct members or comments > This will cause a huge amount of churn, and is a needless change. It makes things harder to read. Though this alignment style has been slowly waining after being popular early on... The comments moving is a bigger problem for the worse. > - space vs tab after #define > - newlines before quoted function arguments > Also a problem since it introduces more verticality. > - function argument wrapping (see write_glyph_buf) > - leading indentation and args-per-line (print_font_info) > An interesting experiment, but there's far more worse after than before. The rearranging of carefully aligned elements is an especially galling change for some people (myself included). Warner