From owner-svn-ports-all@freebsd.org  Tue Jan 23 14:37:51 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15CA9ED6E9B
 for <svn-ports-all@mailman.ysv.freebsd.org>;
 Tue, 23 Jan 2018 14:37:51 +0000 (UTC) (envelope-from ale@FreeBSD.org)
Received: from lab.alexdupre.com (lab.alexdupre.com [93.151.207.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 834B37E973
 for <svn-ports-all@freebsd.org>; Tue, 23 Jan 2018 14:37:50 +0000 (UTC)
 (envelope-from ale@FreeBSD.org)
Received: (qmail 60512 invoked from network); 23 Jan 2018 14:31:06 -0000
Received: from 151-0-207-195.ip282.fastwebnet.it (HELO ale.bitgold.com)
 (sysadmin@alexdupre.com@151.0.207.195)
 by lab.alexdupre.com with ESMTPSA; 23 Jan 2018 14:31:06 -0000
Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
References: <201801231358.w0NDwMa8074241@repo.freebsd.org>
 <20180123140938.GA73049@FreeBSD.org>
From: Alex Dupre <ale@FreeBSD.org>
Message-ID: <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org>
Date: Tue, 23 Jan 2018 15:31:03 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Firefox/52.0 SeaMonkey/2.49.1
MIME-Version: 1.0
In-Reply-To: <20180123140938.GA73049@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2018 14:37:51 -0000

Alexey Dokuchaev wrote:
> On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote:
>> New Revision: 459751
>> URL: https://svnweb.freebsd.org/changeset/ports/459751
>>
>> Log:
>>   The Solidity Contract-Oriented Programming Language
>>   
>>   WWW: https://github.com/ethereum/solidity
>>
>> Added: head/lang/solidity/Makefile
>> ...

Hi Alexey, I often agree with your comments, but this time I have to
strongly disagree.

% portlint -tac solidity/
looks fine.

>> +COMMENT=	Solidity Contract-Oriented Programming Language
> 
> COMMENT=	Contract-oriented programming language

Come on, then the comment for the scala port should be "Programming
Language"?

> 
>> +OPTIONS_DEFINE=	SMT
>> +SMT_DESC=	SMT Checker
>> +SMT_LIB_DEPENDS=libz3.so:math/z3
>> +
>> +USES=		cmake
> 
> Misplaced USES.

I don't see what's misplaced here, portlint doesn't seem to agree with you.

>> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
>> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
>> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"
> 
> And CMAKE_ARGS (also bogus +=).

Really?

>> +pre-patch:
>> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
>> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt
> 
> Excessive indentation of target recipe (commands).

Seriously?

>> Added: head/lang/solidity/pkg-descr
>> ...
>> @@ -0,0 +1,3 @@
>> +The Solidity Contract-Oriented Programming Language
>> +
>> +WWW: https://github.com/ethereum/solidity
> 
> Bad port description (verbatim copy of COMMENT), tells nothing about the
> port (violation of PHB Section 3.2.1).
This is the only thing I agree on, changed.

-- 
Alex Dupre