From owner-freebsd-arch Sun Jan 20 12:43: 7 2002 Delivered-To: freebsd-arch@freebsd.org Received: from straylight.ringlet.net (discworld.nanolink.com [217.75.135.248]) by hub.freebsd.org (Postfix) with SMTP id 3CE9037B405 for ; Sun, 20 Jan 2002 12:43:00 -0800 (PST) Received: (qmail 34688 invoked by uid 1000); 20 Jan 2002 20:43:45 -0000 Date: Sun, 20 Jan 2002 22:43:45 +0200 From: Peter Pentchev To: arch@FreeBSD.org Cc: djm@mindrot.org Subject: sftp, glob(3) and GLOB_NOMATCH - urgent before 4.5-R! Message-ID: <20020120224344.A15845@straylight.oblivion.bg> Mail-Followup-To: arch@FreeBSD.org, djm@mindrot.org References: <20020118223810.D5B0FE92A@shitei.mindrot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020118223810.D5B0FE92A@shitei.mindrot.org>; from bugzilla-daemon@mindrot.org on Sat, Jan 19, 2002 at 09:38:10AM +1100 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, In FreeBSD PR 34019, the submitter discusses an sftp core dump when a nonexistent file is uploaded. I found out that the same bug exists on uploading, and that it is caused by the fact that sftp expects glob(3) to error out when no matches are found. I opened up an OpenSSH problem report (bug id 73 in the mindrot.org database) and soon afterwards, I received the attached reply, which was CC'd to our GNATS. So.. somebody who is acquainted with standards, compatiblity, POLA and stuff - how do we go about this? Do we commit the fix in the audit trail of PR 34019, thus making another local change to OpenSSH? Do we change glob(3)'s behavior to return GLOB_NOMATCH? Or do we ship 4.5 with a known bad sftp client? :) I've CC'd Damien Miller (thanks for the fast response!) so that the OpenSSH folks are also aware of this discussion. G'luck, Peter -- because I didn't think of a good beginning of it. On Sat, Jan 19, 2002 at 09:38:10AM +1100, bugzilla-daemon@mindrot.org wrote: > http://bugzilla.mindrot.org/show_bug.cgi?id=73 > > ------- Additional Comments From djm@mindrot.org 2002-01-19 09:38 ------- > Are you sure it is not your glob() implementation that is incorrect here? sftp > relies on glob to return non-zero (i.e. GLOB_NOMATCH) when no files are matched. > This works correctly on Linux, Solaris and OpenBSD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message