Date: Thu, 8 Jun 2000 23:31:32 +0100 From: Ben Smithurst <ben@scientia.demon.co.uk> To: Szilveszter Adam <sziszi@petra.hos.u-szeged.hu> Cc: ports@freebsd.org, abe@purdue.edu, obrien@FreeBSD.org Subject: Re: lsof port doesn't compile Message-ID: <20000608233132.W42325@strontium.scientia.demon.co.uk> In-Reply-To: <20000608194209.A19752@petra.hos.u-szeged.hu> References: <20000608194209.A19752@petra.hos.u-szeged.hu>
next in thread | previous in thread | raw e-mail | index | archive | help
Szilveszter Adam wrote:
> I am using a -CURRENT box, cvsupped, built today. I am trying to compile
> lsof_4.50A.freebsd.tar.gz from ports, collection also cvsupped today.
>
> But the compile dies with:
>
> (cd lib; make DEBUG="-O" CFGF="-pipe -DFREEBSDV=500 -DHASFDESCFS=2
> -DHASPROCFS -
> DHAS9660FS -DHASIPv6 -DLSOF_VSTR=\"5.0-CURRENT\"")
> cc -pipe -DFREEBSDV=500 -DHASFDESCFS=2 -DHASPROCFS -DHAS9660FS -DHASIPv6
> -DLSOF
> _VSTR=\"5.0-CURRENT\" -I/usr/include -I/usr/src/sys -O -c dnode.c
> dnode.c: In function process_node':
> dnode.c:431: structure has no member named fd_link'
> dnode.c:432: structure has no member named fd_link'
> *** Error code 1
fd_link was part of the fdesc filesystem, but it was removed recently as
it's no longer used.
----------------------------
revision 1.13
date: 2000/06/02 07:02:45; author: chris; state: Exp; lines: +1 -2
- Do not allow VOP_SETATTR to modify underlying vnodes at all. This caused
problems when fetch(1) was passed `-o -'. The rationale of this change
is that applications attempting to change underlying vnodes for /dev/fd
nodes are improperly written and the use of this interface should not
ever have been encouraged. Proper alternatives are fchmod, fchown and
others.
PR: 18952
- Remove stale, unused fdescnode->fd_link structure member.
----------------------------
I've CC'd lsof's author and the FreeBSD port maintainer, they were very
helpful last time I reported a bug in lsof.
I can't really test this properly easily -- my only -current machine is
a 486 which takes nearly 24 hours to do a full buildworld. :-( Compiling
lsof alone is taking long enough... Try this patch anyway, it just
removes references to fd_link:
--- dnode.c~ Thu Jun 8 23:18:32 2000
+++ dnode.c Thu Jun 8 23:19:00 2000
@@ -428,12 +428,8 @@
#if defined(HASFDESCFS)
else if (f) {
- if (f->fd_link
- && kread((KA_T)f->fd_link, Namech, sizeof(Namech) - 1) == 0)
- Namech[sizeof(Namech) - 1] = '\0';
-
# if HASFDESCFS==1
- else if (f->fd_type == Fctty) {
+ if (f->fd_type == Fctty) {
if (f_tty_s == 0)
f_tty_s = lkup_dev_tty(&f_tty_dev, &f_tty_ino);
if (f_tty_s == 1) {
apply it in the "dialects/freebsd" subdirectory of the lsof source
directory after doing "make extract" in the port directory. This
patch compiless, the patched version works on my test system, but as I
said I'm nor running an up-to-date kernel or world so that may not be
relevant.
--
Ben Smithurst / ben@scientia.demon.co.uk / PGP: 0x99392F7D
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000608233132.W42325>