From owner-svn-src-all@FreeBSD.ORG Tue Oct 28 03:43:39 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4DE86587; Tue, 28 Oct 2014 03:43:39 +0000 (UTC) Received: from mail-wg0-x22d.google.com (mail-wg0-x22d.google.com [IPv6:2a00:1450:400c:c00::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A82134A; Tue, 28 Oct 2014 03:43:38 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id x12so2723960wgg.4 for ; Mon, 27 Oct 2014 20:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=2NEOMGr/BIQugsNY4lTK2JJog77epGlEZ7dzD/6yqOo=; b=QidRXjC8fIayPXdRFA7EzHkBP/2D/vNMkVkcbOI9fMlp55L2x0kphFXS+3gv+8s46p 8uJ80veWmHgmfE6I8Ky7irglKkWxbEPdowyToJBd0i968oOdTyIAWc8DCb+iU3/T6d1J lGWY5pXg7H0qZiPX0514jdDlg14RLvtTzDphTYDEAlAX/pqT/My4RzfL2grOGeAotBKG jYh6xB+eaGf5mY78jnnFuF1bo9Y4F6q0irBonOKE/z8DXPXwU+r8Ku/+mXiCCAkB434Y jI3kNEafVbcwiEdhBuydapgLwmc1coDnynz3Ppfc+H4UxEvPdIVE1fGcfdCyVGnBHWnt nnGw== MIME-Version: 1.0 X-Received: by 10.194.157.137 with SMTP id wm9mr663475wjb.5.1414467816544; Mon, 27 Oct 2014 20:43:36 -0700 (PDT) Received: by 10.216.159.193 with HTTP; Mon, 27 Oct 2014 20:43:36 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <235737869.CpTJALnJpW@ralph.baldwin.cx> References: <201410240539.s9O5dWWK002150@svn.freebsd.org> <235737869.CpTJALnJpW@ralph.baldwin.cx> Date: Tue, 28 Oct 2014 11:43:36 +0800 Message-ID: Subject: Re: svn commit: r273576 - head/sys/dev/uart From: Marcelo Araujo To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 03:43:39 -0000 Done: https://svnweb.freebsd.org/base?view=revision&revision=273761 Thank you guys!!!! 2014-10-25 0:14 GMT+08:00 John Baldwin : > On Friday, October 24, 2014 05:39:32 AM Marcelo Araujo wrote: > > Author: araujo (ports committer) > > Date: Fri Oct 24 05:39:32 2014 > > New Revision: 273576 > > URL: https://svnweb.freebsd.org/changeset/base/273576 > > > > Log: > > Fix a leaked Storage Variable. > > > > Phabric: D981 > > Submitted by: myself > > Reported by: Coverity > > CID: 1248848 > > Reworked by: kevlo > > Reviewed by: marcel, davide, ray, kevlo > > Approved by: marcel, kevlo > > > > Modified: > > head/sys/dev/uart/uart_subr.c > > > > Modified: head/sys/dev/uart/uart_subr.c > > > ============================================================================== > > --- head/sys/dev/uart/uart_subr.c Fri Oct 24 04:01:14 2014 > (r273575) > > +++ head/sys/dev/uart/uart_subr.c Fri Oct 24 05:39:32 2014 > (r273576) > > @@ -196,7 +196,7 @@ out: > > int > > uart_getenv(int devtype, struct uart_devinfo *di, struct uart_class > *class) > > { > > - const char *spec; > > + const char *cp, *spec; > > Dropping const here is preferable to using __DECONST() for the freeenv() > calls. > > -- > John Baldwin > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)