From owner-freebsd-ports@FreeBSD.ORG Mon Feb 28 13:45:33 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from chateau.d.if (localhost [IPv6:::1]) by hub.freebsd.org (Postfix) with ESMTP id 127C4106566B; Mon, 28 Feb 2011 13:45:33 +0000 (UTC) (envelope-from ashish@freebsd.org) Received: from chateau.d.if (chateau.d.if [IPv6:::1]) by chateau.d.if (Postfix) with ESMTP id 66EA845612; Mon, 28 Feb 2011 19:15:31 +0530 (IST) From: ashish@FreeBSD.org (Ashish SHUKLA) To: Marius =?utf-8?Q?N=C3=BCnnerich?= Organization: The FreeBSD Project References: <86bp2d1wit.fsf@chateau.d.if> <86oc6dzf1z.fsf@chateau.d.if> <86lj1ah2ce.fsf@chateau.d.if> X-Face: )vGQ9yK7Y$Flebu1C>(B\gYBm)[$zfKM+p&TT[[JWl6:]S>cc$%-z7-`46Zf0B*syL.C]oCq[upTG~zuS0.$"_%)|Q@$hA=9{3l{%u^h3jJ^Zl; t7 X-Uptime: 7:12PM up 32 mins, 3 users, load averages: 0.04, 0.11, 0.15 X-URL: http://people.freebsd.org/~ashish/ X-Operating-System: FreeBSD/FreeBSD 8.2-RELEASE/amd64 X-OpenPGP-Fingerprint: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 X-Attribution: =?utf-8?B?4KSG4KS24KWA4KS3?= Organisation: The FreeBSD Project Date: Mon, 28 Feb 2011 19:15:25 +0530 In-Reply-To: ("Marius =?utf-8?Q?N=C3=BCnnerich=22's?= message of "Mon, 28 Feb 2011 13:42:15 +0100") Message-ID: <86k4gkxoga.fsf@chateau.d.if> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (amd64-portbld-freebsd8.1) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJ1BMVEWpqal/f39tbW1jY2Md HR2goKCenp6UlJROTk7////9/f35+fnT09ORJdieAAACVklEQVQ4jXXUP2vbQBQA8AvUTkgz5OzY Z0iGWhpS6BSrkECn0mvx0MEJ6AjtYrfoBCVDlD8naJYmNlRfwZq8+mkKlIZaGpJSYmP7Q/XkJDrJ Td8i/H68u3vHPaPufwLdf32AMA4A6GcAgvAamY1pOJiDIFqicTwLswDhfr3uxfFtkAY/GFHPMwzD 8zpnACmIOnE6js7rQb+v4NJrG9od0C+QgpHMy5jBewV+UDSMWiw1Y4fWfyV7+NGFzDsYa3pth9LJ Q4XvXxFHcJRvHOmygn5NAEabnDcQQguarnfoiwSCJ99jmKKcphsZONmWsDK9Ro7cvZOCtQdg8nje egLhc2LNlkLmsezzTFUUy5w18ocox/f0LaLgJy0zO75zk+9pp85GAj36xjqhdI0y3tq2m4dqqcWX zQWBTz8L1irvolXV4J+3q7eCDgVnttjNq6X8H+9KOZsuNk1uCzx8pSp+E9HImfJOTLdcGqo+YKnG EIovizkEn48V7BO+ch2DXcD4ENSpWiU+q8hjjbgTBZCXnZtyj0Ws4Q1Q0B2WXFtYZo65Bbyeeldw RS6qFueM80LlLA29YlVwGRYvFD+kwI/0O+A2PlpOP9GwslUVciHuYGechuBTp922YiDZCrghTknm XSyOM+D3aoRZlo0Jb42zY7DN4p2x4AeZ+QAYutx1sHwTHzMT5cMNduQ9yW3GczN4KZ86kb0c9O8T yXDeFqpl2fryPEAYGXIlezAPXYh2NgVr/gvdoHIuDwuPwOhcWE8f8mmICq41eATkn8x0kuRTIKcB wE9+/QUtiiAnYcaN7wAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Cc: Ashish SHUKLA , freebsd-ports@freebsd.org Subject: Re: pdnsd leaking udp sockets X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2011 13:45:33 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius N=C3=BCnnerich writes: > On Sun, Feb 20, 2011 at 21:34, Ashish SHUKLA wrote: >> Hi Marius, >>=20 >> Marius N=C3=BCnnerich writes: >>=20 >> [...] >>=20 >>> Ok, I applied the patch and reinstalled the port. I will leave it >>> running for a few days and report back. So far it's looking good. >>> Thank you very much! :) >>=20 > OK, I had it running for a while now with your fix. It's not leaking anym= ore. > There is still one close() missing before a return in that same function. Yes, you're right. I've updated the original diff[1] in case someone like t= o try it. I'll commit it in a day or two. >> I talked to Paul (the upstream author of pdnsd), and he suggested running >> dns/pdnsd with following command-line (requires devel/valgrind port): >>=20 >> % valgrind --tool=3Dmemcheck --leak-check=3Dyes --track-fds=3D=3Dyes pdn= sd --nodaemon > I'll try this too if I can find the time, but so far it doesn't seem > to leak memory. Cool. References: [1] http://people.freebsd.org/~ashish/diffs/pdnsd-sockets-leak.diff Thanks =2D-=20 Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 freebsd.org!ashish | http://people.freebsd.org/~ashish/ Avoid Success At All Costs !! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQIcBAEBCgAGBQJNa6b6AAoJEMdGz6nnT6Sw5NsP/jCgMbYrrpWkzsJb9z+eunf3 kp1w7BJSC+YJA4pZ+QZf6hR4tFMJQlmddWQ1hkxe19jEzQop/UAxWxTsbGjPWhD+ m8V3e4hoyYfLyE7Nk5goSATPUnEbeBRaZP1+PsI/7qwzpIX5M7nI0wM9wZl3eA0p ljxtXu3O2g7tTh63i51OoqNVDiykN0CjqxpVRPcVKyuwYDIYfELPvbo1DjUIXGVx huR4gZUf7BJmUNlrCOb7la1t09FDiFcTXCBYDVp/awVQCp16SB1I6KrUVK5Ij6wB kc6fjcms2aJNaMC3h1w+hmmtG4BL4rAD6oOkpQ0KvBxGuUOvjeUZDyKV8PKcR1D5 V6kj4vMhPvXrxmbE0elJVEN98PllZVf9R3asVuc4Zkf+V00aUP68qQTLlxOj3L2s SGww1S6QXv9Nb9GRZ1E+p0bPKUt8qCeMmaWq/ksJUKBQWoo7rS5vn1KW8EivgiDV CIRjUSK4SuUqDoDYJrJATMmZDyzDoIn1NaPr36nLMyE2wSjMS++aR3eUgbvSu8dm xWvOEliHki+fSJK7iqxf1WICfKnm9NycfvOAce+EYFDQXpl/CX7MKXImEygncDnx htu5WBjEquH6NgN/UyaeE+arBazNnKPQBiSaZK+9wGHUaUUOrG5Hs9r9J1HyuMPF Qa3nwhXBSUclzGXUqT9t =1q+X -----END PGP SIGNATURE----- --=-=-=--