From owner-svn-src-head@freebsd.org Wed Mar 1 07:16:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2019ACF32AB; Wed, 1 Mar 2017 07:16:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA5571ED; Wed, 1 Mar 2017 07:16:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id b5so374462pfa.0; Tue, 28 Feb 2017 23:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=Judm7PfH7tsTntYRtHTKkdzF9KqaAosT+mI4Ho/SMsg=; b=l2CV3kVD7+lU4TZwcGAHZNSWUmoD5VxsOxNwS1ZAQBRAH5oTECPFcxswCAC1wYOaFL E1WUONUQTyMuvdZt9o6z6YDcYr+F942pYixpLzPcRLF5wYCAeslPHEAW56WA4MqEkzte nMw4xmbUU+XwcA1QDKHMAGJfjtPa5IpCOsyf8fyr9Y9DVMtdlUtJKVJI2jRGk/9o2asx jAvyPY/lnF9Y3a7oYZ0EkMoyJihYdtjXXKR1RnP0A3GxKEFPfXfT+sTUITdvDU0upzss MpZOyKuSH6W4RCgAkQe/afeuzPtCchMfqB/mz8eYjqIAeGMXa8zCDVGExPC1cQ1MQRrn tc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=Judm7PfH7tsTntYRtHTKkdzF9KqaAosT+mI4Ho/SMsg=; b=lYu0Hf2L9DZn77kBFBAJp5iBXC6wmNoWrKGv81Edli8bp9cK903Ld/d1RzIA2fY7rV CYlxWeRKrbgOY91Ov1lNssTpvvdMpSj5+t8zxdZHWF9+RuySk2QzVxuckob/5/9yh1Or HwSrKVUDVQJzlTl+ekxXSMStY7c51BS8dH0tpDHWN4byP0Lf5cPCVd3I1cXPgHbZrgQZ Or6lcCdybCdTarxLsCfyljiqYuUci0Byw/X9bx9S4+O07Zq2dcClgy4rVwc3grwVolHt 4yQZ1t/kklZXsoMbxvbhnSkDI2GOvijVB8mrDTfOKpnVhWKdxFwJm9ksdONDEUIa+Jbw oDLw== X-Gm-Message-State: AMke39liS542CEhJm2fQhUmFSB+UYXruIiN8b9b9wRby4H/ehIae/I20xCrzrVp4/aUokA== X-Received: by 10.84.224.133 with SMTP id s5mr8151019plj.93.1488352615423; Tue, 28 Feb 2017 23:16:55 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 202sm8186641pfa.6.2017.02.28.23.16.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Feb 2017 23:16:54 -0800 (PST) Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_7AA1D18F-7151-4F75-A0EC-614455F1C8A5"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net> Date: Tue, 28 Feb 2017 23:16:53 -0800 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <04EB01C9-6115-44A3-89EB-A8ED37A107E5@gmail.com> References: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net> To: "Rodney W. Grimes" X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 07:16:56 -0000 --Apple-Mail=_7AA1D18F-7151-4F75-A0EC-614455F1C8A5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 28, 2017, at 21:53, Rodney W. Grimes = wrote: >=20 > -- Start of PGP signed section. > [ Charset UTF-8 unsupported, converting... ] >>=20 >>> On Feb 28, 2017, at 21:38, Rodney W. Grimes = wrote: >>>=20 >>> Would it be possible to not do this as 1000 commits? >>=20 >> Yes, but I?m trying to do this in a way that allows me to = backport all of the changes as easily as possible to ^/stable/10 (on the = other side of the coin, I?ve run into dependent commits of other MFCs = that required sweeping changes in order to make my changes possible). >> I do think your point is valid though and I can probably strike = some middle ground with my changes. I think grouping it up by 2nd level = directory (like I did with usr.bin/svn) makes the most sense. >> Thank you, >=20 > Yes, that is what I was thinking. Note that I dont agree with this = change, > but I have probably missed a discussion that is allowing it to move = forward. > It makes the logfiles of make output now src tree possition dependent, > but I am probalby the only person in the universe that has ever run a > diff on the output of make world. It was much the same way before, i.e. .CURDIR was a full path. My doing = this achieves what you described, it helps dumb tools (like Jenkins) = dedupe warnings though, and it also makes it easier to fork/build on = different components in the source tree (I recently embarked on joining = a forked copy of syslogd at $work, and using SRCTOP helps me achieve = that, in the sense that I don=E2=80=99t need to duplicate Makefiles). > It may also be possible to split this into some phases to reduce some = of > your issues, only do the {.CURDIR}/../../foo -> ${SRCTOP}/bar/foo in = one pass and > some of the other fixes in another pass. Yeah. That seems reasonable (I will split it up into larger chunks). Thanks, -Ngie --Apple-Mail=_7AA1D18F-7151-4F75-A0EC-614455F1C8A5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYtnVlAAoJEPWDqSZpMIYVjYEP/1v8c2BjppCdqW0S2avqi3t+ xVbROW5JCL0vRTfizl33T9+Ztcec2LuYTnNaoqmSyHSLa6dO0Wov0MTmxm3Mr6zG v102d1FKEO/f002dBprsWYIftHNEtDmN/K1WD+cHsxf156yUERm/2yKb8aeWs7yv fo2Q4lxI/z0yycdcAl6vmHWu7Bp4aloMPqEErDApEWLqlQxJgWcD96vetdf/iaq2 yF9PvHtaFnuOBE/a6KkDHLcayRk77YTEzvErJ69o1RaMrMxc+VY+htnMbhvs4Isx 1kLWBv5L2Eu7PkyH1Rf7kURtyj+htzkS1DoS8FJzAoUARsisBaQdjjyRqEJ+A3bn G/yyiKIRi1mw687abZOJ30aXm2Qm+l8ruUaz/Cn4s/NJpEl355blQlllqiLKtszz XSv8DyIe+JSvRs/EBRaeW3rQ59X8ppep2+3D4TzWpWNjGJbx1/HvPq87DhfIn0Hs nZxTmDxobTNfLMEoPR1xWXBy2rr68s8HsiN7Rw3dP7MTIGOsgDDquSrGlXBBJq+L GO/c1zhV1KxH2oHGioiSYrM4lmWl31PP43fFpUAWv68WzM00D4n1JbATJ6p3UztZ GaqHvfgaMfpMT7QQwvOA031go1P/xx2nX6jLqYroxizoKpcrGTzbp040POP7KxMh a8hhg6MQeW40O1086n0i =E2aP -----END PGP SIGNATURE----- --Apple-Mail=_7AA1D18F-7151-4F75-A0EC-614455F1C8A5--