From owner-svn-src-all@freebsd.org  Tue Mar  6 02:23:01 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD09BF4326B
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Tue,  6 Mar 2018 02:23:01 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FB897B3DF
 for <svn-src-all@freebsd.org>; Tue,  6 Mar 2018 02:23:01 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 45bd274f-20e5-11e8-91c6-33ffc249f3e8
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id 45bd274f-20e5-11e8-91c6-33ffc249f3e8;
 Tue, 06 Mar 2018 02:22:53 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w262Mmbp097441;
 Mon, 5 Mar 2018 19:22:48 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1520302968.15494.7.camel@freebsd.org>
Subject: Re: svn commit: r330407 - head/sys/dev/iicbus
From: Ian Lepore <ian@freebsd.org>
To: Jonathan Looney <jonlooney@gmail.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Mon, 05 Mar 2018 19:22:48 -0700
In-Reply-To: <CADrOrmvfHn5B4gbhcrPuYc_y_2KzrMVTqevoApRu5WzwOFC_AA@mail.gmail.com>
References: <201803041932.w24JWqei028169@repo.freebsd.org>
 <CADrOrmvfHn5B4gbhcrPuYc_y_2KzrMVTqevoApRu5WzwOFC_AA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2018 02:23:02 -0000

On Mon, 2018-03-05 at 19:05 -0500, Jonathan Looney wrote:
> It looks like this is causing compilation failures:
> 
> /home/jtl/head/sys/dev/iicbus/ds1672.c:147:20: error: use of
> undeclared
> identifier 'sc'
>         clock_dbgprint_ts(sc->sc_dev, CLOCK_DBG_READ, ts);
>                           ^
> /home/jtl/head/sys/dev/iicbus/ds1672.c:162:20: error: use of
> undeclared
> identifier 'sc'
>         clock_dbgprint_ts(sc->sc_dev, CLOCK_DBG_WRITE, ts);
>                           ^
> 2 errors generated.
> 
> 
> Jonathan

Oops, sorry about that.  I didn't realize it wasn't being built as a
module, so I never actually compile-tested it.  Fixed in r330528.

-- Ian


> On Sun, Mar 4, 2018 at 2:32 PM, Ian Lepore <ian@freebsd.org> wrote:
> > > 
> > Author: ian
> > Date: Sun Mar  4 19:32:52 2018
> > New Revision: 330407
> > URL: https://svnweb.freebsd.org/changeset/base/330407
> > 
> > Log:
> >   Add calls to the new clock_dbgprint_xxx() functions.  Also, stop
> > applying
> >   a local .5 second adjustment to the time, since that is now done
> > by the
> >   code in subr_rtc.c.
> > 
> > Modified:
> >   head/sys/dev/iicbus/ds1672.c
> > 
> > 
> >