From owner-svn-src-all@freebsd.org Thu Nov 26 06:59:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94A734A39A6; Thu, 26 Nov 2020 06:59:28 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ChTC43jGtz3K18; Thu, 26 Nov 2020 06:59:28 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7221B1F31B; Thu, 26 Nov 2020 06:59:28 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AQ6xS1W015975; Thu, 26 Nov 2020 06:59:28 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0AQ6xSu8015974; Thu, 26 Nov 2020 06:59:28 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202011260659.0AQ6xSu8015974@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Thu, 26 Nov 2020 06:59:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r368048 - in head/sys: kern sys X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: in head/sys: kern sys X-SVN-Commit-Revision: 368048 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 06:59:28 -0000 Author: mjg Date: Thu Nov 26 06:59:27 2020 New Revision: 368048 URL: https://svnweb.freebsd.org/changeset/base/368048 Log: thread: staticize thread_reap and move td_allocdomain thread_init is a much better fit as the the value is constant after initialization. Modified: head/sys/kern/kern_thread.c head/sys/sys/proc.h Modified: head/sys/kern/kern_thread.c ============================================================================== --- head/sys/kern/kern_thread.c Thu Nov 26 05:58:55 2020 (r368047) +++ head/sys/kern/kern_thread.c Thu Nov 26 06:59:27 2020 (r368048) @@ -143,6 +143,7 @@ static struct task thread_reap_task; static struct callout thread_reap_callout; static void thread_zombie(struct thread *); +static void thread_reap(void); static void thread_reap_all(void); static void thread_reap_task_cb(void *, int); static void thread_reap_callout_cb(void *); @@ -347,7 +348,6 @@ thread_ctor(void *mem, int size, void *arg, int flags) td = (struct thread *)mem; td->td_state = TDS_INACTIVE; td->td_lastcpu = td->td_oncpu = NOCPU; - td->td_allocdomain = vm_phys_domain(vtophys(td)); /* * Note that td_critnest begins life as 1 because the thread is not @@ -420,6 +420,7 @@ thread_init(void *mem, int size, int flags) td = (struct thread *)mem; + td->td_allocdomain = vm_phys_domain(vtophys(td)); td->td_sleepqueue = sleepq_alloc(); td->td_turnstile = turnstile_alloc(); td->td_rlqe = NULL; @@ -663,7 +664,7 @@ thread_reap_all(void) /* * Reap zombies from local domain. */ -void +static void thread_reap(void) { struct thread_domain_data *tdd; Modified: head/sys/sys/proc.h ============================================================================== --- head/sys/sys/proc.h Thu Nov 26 05:58:55 2020 (r368047) +++ head/sys/sys/proc.h Thu Nov 26 06:59:27 2020 (r368048) @@ -1142,7 +1142,6 @@ int thread_create(struct thread *td, struct rtprio *rt void thread_exit(void) __dead2; void thread_free(struct thread *td); void thread_link(struct thread *td, struct proc *p); -void thread_reap(void); int thread_single(struct proc *p, int how); void thread_single_end(struct proc *p, int how); void thread_stash(struct thread *td);