From owner-freebsd-current@FreeBSD.ORG Sat Mar 22 20:03:34 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0D231065672 for ; Sat, 22 Mar 2008 20:03:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id A2E1F8FC1D for ; Sat, 22 Mar 2008 20:03:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 4C08646B45; Sat, 22 Mar 2008 16:03:34 -0400 (EDT) Date: Sat, 22 Mar 2008 20:03:34 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Chuck Robey In-Reply-To: <47E55BD0.2000101@chuckr.org> Message-ID: <20080322200225.C32322@fledge.watson.org> References: <47E55BD0.2000101@chuckr.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: patching X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Mar 2008 20:03:34 -0000 On Sat, 22 Mar 2008, Chuck Robey wrote: > I finally get to the point that I can do some useful coding on some usb > stuff, I make up a patch, update current so that I can compile against it, > and find that someone has broken current. Naughty, naughty. Here's the part > of kdump where it broke: Since we don't have a sys/tablet, I'm wondering if it's perhaps your fault :-). Does your include file have appropriate #ifndef/#define/#endif guards around it to protect you from syntax errors in the event of multiple (possibly nested) include? Robert N M Watson Computer Laboratory University of Cambridge > > ===> usr.bin/kdump (all) > cc -O2 -fno-strict-aliasing -pipe -I/usr/src/usr.bin/kdump/../ktrace > - -I/usr/src/usr.bin/kdump -I/usr/src/usr.bin/kdump/../.. -c > /usr/src/usr.bin/kdump/kdump.c > cc -O2 -fno-strict-aliasing -pipe -I/usr/src/usr.bin/kdump/../ktrace > - -I/usr/src/usr.bin/kdump -I/usr/src/usr.bin/kdump/../.. -c ioctl.c > In file included from ioctl.c:127: > /usr/obj/usr/src/tmp/usr/include/sys/tablet.h:93: error: redefinition of 'struct > synapticshw' > *** Error code 1 > > Hope that's of some help. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.4 (FreeBSD) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFH5VvQz62J6PPcoOkRAgBnAJ4jNmThoQmqDyJ/wlv+vqra/5YI/ACffkSo > 0aN3Hxq0Rwn5HjTDb651Pv0= > =GLzQ > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >