From owner-freebsd-hackers@freebsd.org Sat Aug 26 17:56:12 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D63EDD6D3C for ; Sat, 26 Aug 2017 17:56:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B9D5772B8D for ; Sat, 26 Aug 2017 17:56:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v7QHu6a4062461 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 26 Aug 2017 20:56:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v7QHu6a4062461 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v7QHu6SZ062460 for freebsd-hackers@freebsd.org; Sat, 26 Aug 2017 20:56:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 26 Aug 2017 20:56:06 +0300 From: Konstantin Belousov To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] O_NOATIME support for open(2) Message-ID: <20170826175606.GQ1700@kib.kiev.ua> References: <20170826161827.GA21456@schoggimuss.roe.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170826161827.GA21456@schoggimuss.roe.ch> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2017 17:56:12 -0000 On Sat, Aug 26, 2017 at 06:18:27PM +0200, Daniel Roethlisberger wrote: > I'm trying to implement O_NOATIME support for open(2) in order to > provide a more elegant way for backup/archiving software to > prevent atime clobbering. Except for a 2008 thread on this list > I did not find any material; not sure if anybody is interested in > this or if there are reasons why this was never implemented. Please point out the thread, e.g. by providing a link to the first message in the thread in mailman archive. > > The attached patch against 11.1 implements O_NOATIME support for > open(2); it prevents read(2) and mmap(2) from clobbering atime if > the file descriptor was opened with O_NOATIME. O_NOATIME is only > permitted for root and the owner of the file. Currently it is > only implemented for ufs/ffs. It seems to work for me but has > not been extensively tested. What would happen when additional page-in occurs on the mmaped area ? > > I am interested in feedback from people who know their way around > I/O and VFS code before I extend this to other file systems, make > O_NOATIME tunable by fcntl(2), wire it to the Linux compat layer > and write docs. Does the implementation look sane? Did I miss > something important? > > Specifically, is there a better way to pass O_NOATIME into > vm_mmap_vnode other than adding an additional boolean_t argument? > I did not use an additional mmap flag because that would have > required additional logic to prevent userland from passing the > flag to the mmap syscall. If you need two booleans to the function, consider substituting the arguments with the single u_int flags, and define two flags, one for the writecounted, one for noatime.