From nobody Tue Jul 6 23:48:30 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ED9DA11E33DF for ; Tue, 6 Jul 2021 23:48:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKK566FlXz3pqR for ; Tue, 6 Jul 2021 23:48:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82c.google.com with SMTP id w22so746154qtj.8 for ; Tue, 06 Jul 2021 16:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DfsUyFb7vzkJLt5dT1kHfrDWvpHxylu+MHMLTmRe6iY=; b=NQ7Jt2GGNfQAA7lVFL8pZDq7FsK93uhLYLMvLvaWjHoXKdXsxxk4V8s13w2JX7p8zk aeCrSD7OSK5XqdZOEECvbvsGQIkwqZcLVUxSdbmpZIrdQF/6xMxSZ6sBFt/y0H/Rvsaz zxlRm9rSwuFxePato9f9bUw9JdkWaW7/9u28wRuM2IwnbFTbYqQCSEwD+rFnJVoGfg3R whrln6F1m9mGFp/JSa++v0ln59phA4E9obCBthfziUnv5gx/vXnWB238MXiCUp+3KJzH 3SFPr2024oX7W/dYGvywjQnJSQQxVdGIJMXjjKwiGhaOPlV2A+LvOgDvozrKYpMzEERk ET9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DfsUyFb7vzkJLt5dT1kHfrDWvpHxylu+MHMLTmRe6iY=; b=mjZrwpPvJjB1w7y0TW0mfAcOzGoKC7OlH+QHvnyCtarXCZV9ts+hOF4ZDXdoU1RuQO e4gfrKIg9PlhSyXKWyIZT5fMoI8R0t8OTTl4sx7TmqZgvsyikaw5sVx2wiuXurWvS/oM t+qC9F5Z6Cj/RgbYd6KjiW/PKFJWnf6HXHxsfQuRu5IllOoYed7B9Wdt9Pr9K8h/90jB jTRvI43dmVHl1km1kVVRopS/yN2TIfE3+S2uK2BJWkKqGZAxuCBgoaGxE5VdummBi5a7 6Fey0M0A2DY1h3v1xFspT1oAA5IRSWh/ZBripMXEhp40qi5PHzj6dyAmd0XmIZh4o6PJ vehw== X-Gm-Message-State: AOAM531Exjy14FAM4j/eCZPirV8Dtl6JJBagPpCE0A/C6VZrikFVyjr7 yjtTg+JEOoQPEZL3LL5cnoofzE9igDu+riQ0AbbFjzDyMsggaw== X-Google-Smtp-Source: ABdhPJyneikSak7QcWfysGRpBAeqHUKuF+5brlHEOgCxzVwhI+W1ytwbB5Lz4nfKKXLNRcJvEjkVwuL+wyYMjwyvH9A= X-Received: by 2002:ac8:43c2:: with SMTP id w2mr15683976qtn.235.1625615321499; Tue, 06 Jul 2021 16:48:41 -0700 (PDT) List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Tue, 6 Jul 2021 17:48:30 -0600 Message-ID: Subject: Re: MMCCAM sdhci_fdt0 panic on boot To: "Bjoern A. Zeeb" Cc: "freebsd-arm@freebsd.org" , Warner Losh Content-Type: multipart/alternative; boundary="000000000000c79b9e05c67d0f05" X-Rspamd-Queue-Id: 4GKK566FlXz3pqR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: Y --000000000000c79b9e05c67d0f05 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 6, 2021 at 5:31 PM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On Tue, 6 Jul 2021, Bjoern A. Zeeb wrote: > > > Hi, > > > > something has recently changed which causes this (last kernel was from > > April 20 imho and was fine)? > > I am wondering if it is because of MMCCAM/CAM updates or a DTS update I > > didn't fully do and we don't handle well? > > My guess is the former... > > replying to myself after looking at the code; > I am almost certain it's this one: > > https://cgit.freebsd.org/src/commit/sys/dev/sdhci/sdhci.c?id=a72af82e3169fcacfedf9047120679300a4296f8 > > Given the previous version did pass that: > > https://cgit.freebsd.org/src/commit/sys?id=aeb04e88f51a706ef4b6a380bf5e82d15203fb6a > > I'll run a quick test using this before committing. > > diff --git sys/dev/sdhci/sdhci.c sys/dev/sdhci/sdhci.c > index bd30175e9f8..d075c2e0500 100644 > --- sys/dev/sdhci/sdhci.c > +++ sys/dev/sdhci/sdhci.c > @@ -2484,7 +2484,7 @@ sdhci_start_slot(struct sdhci_slot *slot) > > mtx_init(&slot->sim_mtx, "sdhcisim", NULL, MTX_DEF); > slot->sim = cam_sim_alloc(sdhci_cam_action, sdhci_cam_poll, > - "sdhci_slot", slot, device_get_unit(slot->dev), > + "sdhci_slot", slot, device_get_unit(slot->bus), > &slot->sim_mtx, 1, 1, slot->devq); > > if (slot->sim == NULL) { > You're correct. slot->dev is unused for MMCCAM it seems. I don't know what I was thinking when I made the earlier change. Warner --000000000000c79b9e05c67d0f05--