From owner-freebsd-hackers@FreeBSD.ORG  Mon Jun  1 20:28:24 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 993F110656BF
	for <freebsd-hackers@freebsd.org>; Mon,  1 Jun 2009 20:28:24 +0000 (UTC)
	(envelope-from bruce@cran.org.uk)
Received: from muon.cran.org.uk (brucec-1-pt.tunnel.tserv4.nyc4.ipv6.he.net
	[IPv6:2001:470:1f06:c09::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 5520B8FC22
	for <freebsd-hackers@freebsd.org>; Mon,  1 Jun 2009 20:28:24 +0000 (UTC)
	(envelope-from bruce@cran.org.uk)
Received: from muon.cran.org.uk (localhost [127.0.0.1])
	by muon.cran.org.uk (Postfix) with ESMTP id 2901619235;
	Mon,  1 Jun 2009 20:28:23 +0000 (GMT)
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on muon
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=8.0 tests=AWL,BAYES_00,NO_RELAYS
	autolearn=ham version=3.2.5
Received: from gluon.draftnet (unknown
	[IPv6:2a01:348:10f:0:240:f4ff:fe57:9871])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by muon.cran.org.uk (Postfix) with ESMTPSA;
	Mon,  1 Jun 2009 20:28:23 +0000 (GMT)
Date: Mon, 1 Jun 2009 21:28:19 +0100
From: Bruce Cran <bruce@cran.org.uk>
To: Eitan Adler <eitanadlerlist@gmail.com>
Message-ID: <20090601212819.7fa6598e@gluon.draftnet>
In-Reply-To: <4A22F7CD.2070500@gmail.com>
References: <4A22F7CD.2070500@gmail.com>
X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.2)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/BgQzk8W+yfZojiEAKH8FaXk"
Cc: freebsd-hackers@freebsd.org
Subject: Re: pkg_info segfault Revision: 193189
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2009 20:28:25 -0000

--MP_/BgQzk8W+yfZojiEAKH8FaXk
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sun, 31 May 2009 17:34:05 -0400
Eitan Adler <eitanadlerlist@gmail.com> wrote:

> pkg_info --IwantAcookie
> Segmentation fault: 11 (core dumped)
> on FreeBSD 7.2-STABLE i386

getopt_long expects the array of options to be NULL-terminated, so it's
walking off the end.

-- 
Bruce Cran
--MP_/BgQzk8W+yfZojiEAKH8FaXk
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=main.c.diff

--- /usr/src/usr.sbin/pkg_install/info/main.c	2008-06-10 10:55:25.000000000 +0100
+++ main.c	2009-06-01 21:25:37.000000000 +0100
@@ -58,6 +58,7 @@
 	{ "verbose",	no_argument,		NULL,		'v' },
 	{ "version",	no_argument,		NULL,		'P' },
 	{ "which",	required_argument,	NULL,		'W' },
+	{ NULL,		0,			NULL,		0   },
 };
 
 int

--MP_/BgQzk8W+yfZojiEAKH8FaXk--