From owner-freebsd-current Fri Nov 8 5:29: 0 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 600DE37B401 for ; Fri, 8 Nov 2002 05:28:59 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6123A43E3B for ; Fri, 8 Nov 2002 05:28:57 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gA8DSfOr043644; Fri, 8 Nov 2002 14:28:41 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Gerald Pfeifer Cc: Pierre Beyssac , Pierre Beyssac , Dag-Erling Smorgrav , Krzysztof J?druczyk , freebsd-current@freebsd.org, Alfred Perlstein Subject: Re: Wine-2002.10.07 port on FreeBSD 5.0-current In-Reply-To: Your message of "Fri, 08 Nov 2002 14:18:17 +0100." Date: Fri, 08 Nov 2002 14:28:41 +0100 Message-ID: <43643.1036762121@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , G erald Pfeifer writes: >Sheesh. > >PHK, now we have the situation where user programs require #ifdefs >to be portable among the BSDs when this was not required before. > >Please consider reverting That has been considered, and I don't think it is a sensible solution, unless we can get rid of the DBREG_DRX() macro which was the cause of the evilness: struct dbreg { unsigned int dr0; /* debug address register 0 */ unsigned int dr1; /* debug address register 1 */ unsigned int dr2; /* debug address register 2 */ unsigned int dr3; /* debug address register 3 */ unsigned int dr4; /* reserved */ unsigned int dr5; /* reserved */ unsigned int dr6; /* debug status register */ unsigned int dr7; /* debug control register */ }; #define DBREG_DRX(d,x) ((&d->dr0)[x]) /* reference dr0 - dr7 by register number */ If you tell me that DBREG_DRX is a FreeBSD only macro, then we should nuke it and then I will not object to going back to the previous structure definition. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message